Add support for new update types #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twojtasz
reviewed
May 13, 2019
| @@ -21,3 +22,11 @@ export const LOG_STREAM_MESSAGE = { | |||
| ERROR: 'ERROR', | |||
| INCOMPLETE: 'INCOMPLETE' | |||
| }; | |||
|
|
|||
| export const STATE_UPDATE_TYPE = { | |||
| complete_state: 'COMPLETE', | |||
There was a problem hiding this comment.
nit: I prefer the consistency of the string being the same as the key, unless there is a reason to not do this.
twojtasz
approved these changes
May 13, 2019
There was a problem hiding this comment.
It seemed strange if snapshot is semantically closer to incremental, yet in nearly all the test cases the change was snapshot => complete_state. The semantic differences have to do with the TIME_WINDOW in the log synchronizer, so i realized that if we just have a single sample then there is no semantic difference.
I think we need some additional tests on the logSynchronizer independent of this, which you may already ahve in the works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.