Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test coverage #62

Merged
merged 2 commits into from Sep 6, 2018
Merged

Fix test coverage #62

merged 2 commits into from Sep 6, 2018

Conversation

ibgreen
Copy link
Contributor

@ibgreen ibgreen commented Sep 6, 2018

For #61

Background

  • Babel 7 is here and offers real JavaScript config file support, facilitating monorepo setups.
  • Upgrade babel-istanbul to v5 to fix coverage, v4 had very significant issues with the monorepo setup...

Copy link
Contributor

@twojtasz twojtasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments inline


const config = CONFIG[env] || CONFIG.default;
// Uncomment to debug
console.error(env, config.plugins);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment out before merging

test/index.js Outdated
@@ -1,4 +1,4 @@
// Set up a configuration (TODO/OSS - this should be a neutral config)
import './modules/builder';
import './modules/parser';
import './modules/schema';
// import './modules/schema';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this breaking something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlisee @twojtasz The schema tests disable our other tests, so commenting them out for now in order to get progress on coverage.

@ibgreen ibgreen merged commit 3926905 into master Sep 6, 2018
@ibgreen ibgreen deleted the ib/coverage branch September 6, 2018 15:07
jlisee pushed a commit that referenced this pull request Sep 7, 2018
twojtasz pushed a commit that referenced this pull request Jan 22, 2019
twojtasz pushed a commit that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants