Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backend/repository out of zanzibar #338

Closed
ChuntaoLu opened this issue Feb 22, 2018 · 2 comments
Closed

Move backend/repository out of zanzibar #338

ChuntaoLu opened this issue Feb 22, 2018 · 2 comments
Assignees

Comments

@ChuntaoLu
Copy link
Contributor

backend/repository, as an application relies on Zanzibar, does not really need to be part of Zanzibar.

@Raynos
Copy link
Contributor

Raynos commented Feb 28, 2018

The reason it's in zanzibar is because it's very easy to break backend when making changes in zanzibar.

The backend module is responsible for WRITING configs to disk.
The codegen module is responsible for READING configs from disk.

If you make any changes to codegen related to configs your likely to break backend.

If you do move the backend thing out; you should evaluate if you can call INTO uber jenkins from travis and effectively run the test suite for backend with the "new version" of zanzibar.

When we were actively developing and working on backend & codegen we would often make changes to codegen and then not update backend.

whomever was unlucky enough to update the version of zanzibar in backend had to make all of the unrelated changes in one go :(

@ChuntaoLu
Copy link
Contributor Author

@Raynos Thanks for the insights. The team is aware of the tradeoff of the proposed change.

The tempo of config changes has slowed down compared to the earlier development period, which makes not having backend in zanzibar more manageable that it used to be. Also, the team working on internal projects sometimes needs to make awkward changes to work around the fact that backend is open source.

Your comments are absolutely on point, we will need to be more conscious about the impact of future zanzibar changes and improve team communications to ease the version bump process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants