Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

Implement vertical grid #36

Closed
wants to merge 1 commit into from
Closed

Conversation

gigablah
Copy link

most, if not all, logic was built around the idea that at any point the other axis could be supported with minor/moderate code changes

So I took a stab at implementing vertical orientation... not as simple as suggested :)

The code looks rather ugly at the moment and I'm sure lots of refactoring is needed, but I'd like to run it by you first to see if I'm on the right track.

Vertical grids are created by specifying cols instead of rows, e.g.

var myGrid = new GridList(items, {cols: 5});

Demo page is here: http://gigablah.github.io/grid/index-vertical.html

@ovidiuch
Copy link
Contributor

@gigablah this is very exciting! Can't wait to take a more in-depth look this week. Kudos for taking the initiative to take the brave task onto yourself (the one that we shamefully underestimated :p)

First impression from the demo: I think the pullToLeft logic should also adapt to something like pullToTop in vertical mode.

A few collision bugs: https://www.dropbox.com/s/vl026hfdl21fmu4/vertical-grid.mov

@oisinlavery
Copy link

+1

@kamilbrk
Copy link

kamilbrk commented Jun 6, 2014

+1 here

@atsjj
Copy link

atsjj commented Jun 20, 2014

👍

@adamyonk
Copy link

@gigablah If I can be of assistance here, let me know. I'm very anxious to get off of gridster, and this is the main hangup.

@areski
Copy link

areski commented Oct 1, 2014

+1

1 similar comment
@chrispadfield
Copy link

+1

@yamila-fraiman
Copy link

Hi! Thank you very much. I'd like to implement pull to top-left in order to prevent empty slots.
Could you help me?

@HugoHeneault
Copy link

Any news, any updates about this ? It would be great to use it without collisions ! 👍

@thelinuxlich
Copy link

Why this PR didn't get merged?

@ovidiu-chereches-hs
Copy link

Why this PR didn't get merged?

The solution was incomplete and it had some bugs.

But we'll be working on vertical support internally as well, and I expect us to release an update in the coming weeks.

@gigablah
Copy link
Author

gigablah commented Jul 8, 2015

Hi all,

Sorry for the inactivity -- I've since abandoned the branch since I've moved on to a different framework-specific solution. Glad to know that this is being worked on internally. I'll close this PR then.

@gigablah gigablah closed this Jul 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet