This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
findLeftMostPositionForItem logic is flawed #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skidding please review. |
|
LGTM |
|
@skidding please review. |
|
LGTM |
andrei-picus-hs
added a commit
that referenced
this pull request
Aug 21, 2015
findLeftMostPositionForItem logic is flawed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
The _findLeftMostPositionForItem method is only checking for items on the same row as the given item. We should change it to check for items across the entire height of the item.
TODO