Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract Field class from which FiniteDifferenceField and FiniteElementsField can be derived #2

Closed
marijanbeg opened this issue Jul 27, 2016 · 3 comments
Closed

Abstract Field class from which FiniteDifferenceField and FiniteElementsField can be derived #2

marijanbeg opened this issue Jul 27, 2016 · 3 comments
Assignees
@marijanbeg
Labels
discretisedfield refactoring

Comments

@marijanbeg
Copy link
Member

marijanbeg commented Jul 27, 2016 •
edited

An abstract Field class should be created in a new repository, so that both finite difference and finite element fields can be derived from it.

An appropriate repository name would probably be discretisedfield (with British "s"), because this name is available in PyPI.
@marijanbeg marijanbeg self-assigned this Jul 27, 2016
@marijanbeg
Copy link
Member Author

marijanbeg commented Jul 27, 2016 •
edited

Probably a better solution would be to have a single repository discretisedfield which is going to contain the following classes:

  • abstract Field
  • derived FiniteDifferenceField(Field)
  • derived FiniteElementField(Field)

@marijanbeg marijanbeg changed the title Make abstract Field class from which finitedifferencefield will be derived. Abstract Field class from which FiniteDifferenceField and FiniteElementsField can be derived Jul 28, 2016
@marijanbeg marijanbeg mentioned this issue Jul 28, 2016
Closed
@marijanbeg
Copy link
Member Author

Having those fields, fidimag and finmag codes can use them. This way, lots of duplication would be avoided.

@marijanbeg marijanbeg mentioned this issue Jul 28, 2016
Closed
@marijanbeg
Copy link
Member Author

This is now implemented in discretisedfield.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marijanbeg marijanbeg

Labels
discretisedfield refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marijanbeg