Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layer-info): content updates #541

Merged
merged 8 commits into from
Aug 31, 2020
Merged

feat(layer-info): content updates #541

merged 8 commits into from
Aug 31, 2020

Conversation

pmast
Copy link
Member

@pmast pmast commented Aug 27, 2020

Might be controversial: added HTML support for React markdown in the layers-info to support the extended legend for landcover:

image

@pmast pmast changed the title Feat content updates feat(layer-info): content updates Aug 28, 2020
@pmast pmast requested a review from mrMetalWood August 28, 2020 11:04
@mrMetalWood
Copy link
Contributor

Not sure about the HTML support and its implications. Lets see what @pwambach says :) Fine with me

@pmast pmast merged commit 2cd3c5a into develop Aug 31, 2020
@pmast pmast deleted the feat-content-updates branch August 31, 2020 13:19
@pwambach
Copy link
Contributor

Actually I would have preferred to not enable html injects because it's always a security issue to insert html from a remote server. In our case it's not user generated so it "should" be ok, but you never know...

@pmast
Copy link
Member Author

pmast commented Aug 31, 2020

I can also try and work with an image instead. I will give it a try later.

@pwambach
Copy link
Contributor

pwambach commented Sep 1, 2020

But we would need one image per language :(

@pmast
Copy link
Member Author

pmast commented Sep 1, 2020

True…

@pmast
Copy link
Member Author

pmast commented Sep 1, 2020

Is there an option for screenshotting HTML elements with transparent background?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants