Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add props validation #33

Closed
izziaraffaele opened this issue Sep 8, 2015 · 2 comments
Closed

Add props validation #33

izziaraffaele opened this issue Sep 8, 2015 · 2 comments

Comments

@izziaraffaele
Copy link

It's very common in the React world to use React.PropTypes not just for validation of component's props but also to have a clear picture of all the props that a component manage and for documentation.

In getDefaultProps is better to define just conditional props since mandatory props will be in any case overwritten.

An inspiration can be found on the PR I submitted #29
@ro-ka
Copy link
Contributor

ro-ka commented Sep 9, 2015

A breaking change as far as I can see would be that the radius is required as a number, not a String as it is now. What else would be affected? Would like to bundle breaking changes for a master release.

@ro-ka ro-ka closed this as completed in 7d68a02 Mar 11, 2016
@ro-ka
Copy link
Contributor

ro-ka commented Mar 11, 2016

Released in 1.19.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ro-ka @izziaraffaele