Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BEM class naming #36

Closed
izziaraffaele opened this issue Sep 8, 2015 · 3 comments · Fixed by #217
Closed

Fix BEM class naming #36

izziaraffaele opened this issue Sep 8, 2015 · 3 comments · Fixed by #217
Assignees
Labels
Milestone

Comments

@izziaraffaele
Copy link

The Block is "geosuggest" while items are "input", "suggests" and "suggest-item".

So "geosuggest-item" here https://github.com/ubilabs/react-geosuggest/blob/master/src/GeosuggestItem.jsx should be changed to geosuggest__suggest-item

The --focus modifier should be added and used instead of https://github.com/ubilabs/react-geosuggest/blob/master/src/geosuggest.css#L20

@ro-ka
Copy link
Contributor

ro-ka commented Sep 9, 2015

As this is not urgent, I would delay this until there is a breaking change for some other reason. Only breaking and releasing a new master version because of the classes doesn’t make much sense.

@ro-ka ro-ka added the breaking label May 27, 2016
@ro-ka ro-ka added this to the v2 milestone May 27, 2016
@aybmab
Copy link

aybmab commented Aug 17, 2016

Instead of using BEM, which seems to be dying and out of use, can we support the passing in of a styles object that maps expected class names to classnames provided by users?

@ro-ka
Copy link
Contributor

ro-ka commented Aug 19, 2016

That’s a nice idea, too. But still this would be a breaking change. As we don’t want to break, this is moved to a distant future date.

@Scarysize Scarysize self-assigned this Oct 7, 2016
@Scarysize Scarysize mentioned this issue Oct 7, 2016
4 tasks
@yfr yfr closed this as completed in #217 Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants