New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting of matched text doesn't work as expected. #396

Closed

thevarunraja opened this issue Aug 27, 2018 · 0 comments · Fixed by #509

Labels

bug help wanted

thevarunraja commented Aug 27, 2018

Short description

Please compare the highlighting of the text (especially the first option) it doesn't match with googles highlighting implementation.

Expected results

The highlighting of the text should work similar to google highlighting https://developers.google.com/maps/documentation/javascript/examples/places-autocomplete-addressform

Reproduction steps

Go to http://ubilabs.github.io/react-geosuggest/
Enter "1917 old brick rd" in the input field.
Compare the text highlighting with https://developers.google.com/maps/documentation/javascript/examples/places-autocomplete-addressform they don't match.

ro-ka added bug help wanted labels

plumdumpling mentioned this issue

Fix/highlight matched substrings #509

Merged

4 tasks

plumdumpling closed this as completed in #509

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment