Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Point package.json main to built file #4

Closed
alistairjcbrown opened this issue Jun 29, 2015 · 1 comment
Closed

Point package.json main to built file #4

alistairjcbrown opened this issue Jun 29, 2015 · 1 comment

Comments

@alistairjcbrown
Copy link
Contributor

It would be worth updating the main property in the package.json file to point to dist/react-geosuggest.js (or equivalent pure JS file if that's not suitable) so that using require to pull react-geosuggest doesn't first require a build step.

For me, as this component is JSX, I have to update my webpack config and jest preprocessor script to include react-geosuggest as an allowed node_modules library to be included as part of the build.
@alistairjcbrown alistairjcbrown mentioned this issue Jul 1, 2015
Merged
@ro-ka
Copy link
Contributor

ro-ka commented Jul 2, 2015

Thanks for the PR!

As I use JSX for all React stuff, this issue didn’t appear. Released as 1.2.2 on npm.

@ro-ka ro-ka closed this as completed Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alistairjcbrown @ro-ka