Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audits: Owed Payments (Unpaid But Permitted) #4

Closed
0x4007 opened this issue Apr 12, 2023 · 7 comments
Closed

Audits: Owed Payments (Unpaid But Permitted) #4

0x4007 opened this issue Apr 12, 2023 · 7 comments

Comments

@0x4007
Copy link
Member

0x4007 commented Apr 12, 2023

A particularly useful feature now that we sort of have permits on hold: the ability to check if a permit was generated but the payout was not claimed yet.


Update Jan 2024:

We have a new column in the database that is meant to store the claim transaction link.

Whenever the user claims using this UI, the UI should write the claim transaction link to the database.

If the value in the database is null then it implies that the permit was not claimed.

@alankritdabral

This comment was marked as resolved.

This comment was marked as off-topic.

@molecula451
Copy link
Member

A particularly useful feature now that we sort of have permits on hold: the ability to check if a permit was generated but the payout was not claimed yet.

Permits on hold? i guess we can close this or too outdated

@0x4007
Copy link
Member Author

0x4007 commented Mar 6, 2024

It just means generated but not claimed. It's still relevant I think. Unless that was already implemented then yes we can close as unplanned. @FernandVEYRIER rfc

@gentlementlegen
Copy link
Contributor

As of today, we should be seeing these permits as well. I they are not claimed, we should not have any link to the transaction but see the issue. However I don't think there would be any UI difference with the ones not claimed, or if there is no permit at all with the issue.

@0x4007
Copy link
Member Author

0x4007 commented Mar 6, 2024

You can close as not planned @FernandVEYRIER if you think this is not necessary.

@gentlementlegen gentlementlegen closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
Copy link

ubiquibot bot commented Mar 6, 2024

# Issue was not closed as completed. Skipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants