Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreliable Followups/Unassignment #408

Closed
0x4007 opened this issue Jun 15, 2023 · 8 comments · Fixed by #413
Closed

Unreliable Followups/Unassignment #408

0x4007 opened this issue Jun 15, 2023 · 8 comments · Fixed by #413

Comments

@0x4007
Copy link
Member

0x4007 commented Jun 15, 2023

The bot seems to be inconsistent on who it follows up with and then unassigns when dealing with bounties that are assigned but have no updates happening. This is an important feature that should be functional, or else we will have many bounties being reserved and neglected.

I have a feeling that this stopped being reliable after implementing the capability for the bot to monitor linked pull requests for updates. But this feeling may be unfounded cause I haven't done the research to confirm it.

          Thanks @pavlovcik. will complete this asap

Originally posted by @sweetapplepumpkinpie in #176 (comment)


I will compile examples as I find them.

@wannacfuture
Copy link
Contributor

wannacfuture commented Jun 16, 2023

/start

@ubiquibot
Copy link

ubiquibot bot commented Jun 16, 2023

@wannacfuture The time limit for this bounty is on Sat, 17 Jun 2023 04:35:24 GMT

Your currently set address is:
0x9e4EF4353C928cD3eb473E8f12aeCF58C208ef40
please use /wallet 0x4FDE...BA18 if you want to update it.

@wannacfuture
Copy link
Contributor

@pavlovcik , could you provide more information in detail? So, what the bot should do about the bounties with no update?

@0x4007
Copy link
Member Author

0x4007 commented Jun 16, 2023

The bot should follow up as it does on some bounties (I am assuming it is only working on bounties with an open pull request right now. Before it worked on any assigned bounty with no activity!)

The thing is, in the linked example above, the bounty hunter never even started the task. It already has been a full week so they should have already been unassigned by now.

This bounty requires that you figure out the root cause of the issue, as well as provide a fix.

This is an important feature because at any given moment there may be many bounties assigned and then the bounty hunters stop working on them which means that our organization's development throughput will decrease.

@wannacfuture
Copy link
Contributor

wannacfuture commented Jun 16, 2023

The thing is, in the linked example above, the bounty hunter never even started the task. It already has been a full week so they should have already been unassigned by now.

The reason of not unassigning is there is a comment of that bounty hunter which is created less than a week before.
It seems the bot identifies it as it has activity.

So, let's clarify.

  • We should identify issue with only pull request on it even it has comments of the hunter.
  • If there is no opened pr on it and it has passed over followup time, the bot should follow up that issue.
  • And also, even if the issue has opened pr, we should calculate how many time has passed since that pr is created, then if it is over the followup time, the bot also should follow up that issue.

What do you think, @pavlovcik ?

@wannacfuture
Copy link
Contributor

@pavlovcik , Can you check my thoughts above?

@0x4007
Copy link
Member Author

0x4007 commented Jun 18, 2023

The reason of not unassigning is there is a comment of that bounty hunter which is created less than a week before.
It seems the bot identifies it as it has activity.

There are two "checkpoints"

  1. the follow up, where the bot comments "do you have any updates?" this is in about 4 days.
  2. the unassign, where the bot will unassign if there is no reply to that question.

The bot should be following up when activity is not visible from the bounty hunter. "Activity" includes:

  1. comments on the issue from the bounty hunter.
  2. commits on the linked pull request from the bounty hunter.
  3. comments on the linked pull request from the bounty hunter.

Any of those actions should reset the clock for the bot to follow up AND for unassign. This means that if the bot asks for an update, and the bounty hunter adds a new commit, the bot should wait another four days until it asks for updates again.

@ubiquibot
Copy link

ubiquibot bot commented Jun 20, 2023

[ CLAIM 450 WXDAI ]

0x9e4EF435...8C208ef40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Passed
Development

Successfully merging a pull request may close this issue.

2 participants