Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solutionFolder doesn't seem to work in AddProject<> #64

Closed
DjangoLowe opened this issue Jul 29, 2019 · 3 comments
Closed

solutionFolder doesn't seem to work in AddProject<> #64

DjangoLowe opened this issue Jul 29, 2019 · 3 comments

Comments

@DjangoLowe
Copy link

Hi!!

I'm trying to organize the projects in my solution with solution folders and I notice that AddProject<> has a solutionFolder parameter in it. I added a name to it and generated the solution and nothing changed.

Am I doing this wrong?

Thanks for your help!

@ghost
Copy link

ghost commented Jul 29, 2019

You're not doing it wrong, it's a known bug. The fix was merged upstream a few weeks ago but hasn't made it into the public repo yet. I'll see if I can do something about that at work, but in the meantime you have some options:

  1. If your projects are only in one solution (or they're in the same folder regardless of solution), you can set the Project.Configuration.SolutionFolder property during the configuration stage.
  2. If one or more projects have folders that must be set per-solution, you can fix the bug on your end. It's a pretty simple one, and most of the relevant code to change is here.

Basically, the problem is that Sharpmake doesn't recognize that the value passed to AddProject takes precedence over the value set on Project.Configuration.SolutionFolder, sees that the two are different, and blanks out the result. If you can prevent that code from erasing the folder, you should be all set until the official fix rolls in.

@DjangoLowe
Copy link
Author

Awesome, I will give it a shot. should I fork the repo and create a pull request of the result if I get it working?

@ghost
Copy link

ghost commented Jul 30, 2019

We'll see. If I can get the official fix into this repo then there's no need, but feel free to make a request if things take too long :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant