New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation #631

Closed

JanGalek opened this issue Mar 21, 2018 · 1 comment · Fixed by #633

Contributor

JanGalek commented Mar 21, 2018 •

edited

Nette\Component-model v2.4.0 update has construct params deprecated:
https://github.com/nette/component-model/blob/v2.4.0/src/ComponentModel/Component.php#L35-L46

actual:

$grid = new DataGrid($this, $name);

now:

$grid = new DataGrid();
$this->addComponent($grid, $name);

Member

f3l1x commented Mar 21, 2018

@JanGalek Don't hesitate to send PR ;-) It's always welcomed.

JanGalek mentioned this issue

Fix: parent component #633

Merged

paveljanda closed this as completed in #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment