feat: Deprecate looking-glass shm in favor of kvmfr module #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HikariKnight
force-pushed
the
just-kvmfr
branch
from
3ce2452
to
9162243
Compare
HikariKnight
force-pushed
the
just-kvmfr
branch
from
9162243
to
8676f66
Compare
|
Forgot that i needed to edit |
If someone has a better way to implement this regex, hit me up! i just happened to know how to do this with perl as i couldnt figure it out with sed
…eboot use it when enabling.
|
This is now ready to be reviewed and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft until I have done proper testing on my system and should finalize us moving over to the kvmfr module.
The module has been compiled using the makefile from LookingGlass/module and is not modified by us in any way, and is currently pinned to B7-rc1 until a new RC release is made.
The package is just a dkms to akmod conversion in order to work with atomic desktops (essentially compile the module and put it in the right place and tell akmods to rebuild with kernel), no changes has been made to the upstream code.
Users still have to manually compile the looking-glass-client using upstream documentation, this is to avoid any invalid bug reports to the LookingGlass team since the project is still experimental.
This PR will update the just recipe that enabled looking-glass support to enable the kvmfr module, apply the correct udev rules and add the SElinux context record required for kvmfr to work.