Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openrgb rules #32

Closed
Arcitec opened this issue May 7, 2023 · 5 comments
Closed

Update openrgb rules #32

Arcitec opened this issue May 7, 2023 · 5 comments

Comments

@Arcitec
Copy link
Contributor

Arcitec commented May 7, 2023

I just noticed something. The ublue/config OpenRGB rules are severely outdated (missing like 50 new rules). We should definitely have a build step that fetches the freshest rules from upstream automatically.

In the case of OpenRGB, the instructions are posted on their Flathub page, and says that the latest rules are always at the following URL:

  • https://gitlab.com/CalcProgrammer1/OpenRGB/-/jobs/artifacts/master/raw/60-openrgb.rules?job=Linux+64+AppImage&inline=false

I dunno how such an automated fetch step should look like, though. I.e. it should probably fall back to the most recently cached file if fetch fails.

We need the same for the other rules too, such as game devices.

If this can be automated, it removes 1 more maintenance burden from uBlue.

@castrojo castrojo changed the title We should automate all udev device rule imports Update openrgb rules May 7, 2023
@castrojo
Copy link
Member

castrojo commented May 7, 2023

It looks like these are in fedora now, I think we'll just remove them from here but then add them in main.

@Arcitec
Copy link
Contributor Author

Arcitec commented May 7, 2023

@castrojo Nice discovery, I see the change:

ublue-os/main#197

What do you think about the other rules, like game-devices? Anything that isn't in Fedora's repos would be nice to automatically fetch from upstream.

@castrojo
Copy link
Member

castrojo commented May 7, 2023

The game devices one are updated every day already

@Arcitec
Copy link
Contributor Author

Arcitec commented May 8, 2023

The game devices one are updated every day already

Brilliant. Is there anything remaining that would benefit from automatic pulling, or should we close this ticket now? :)

@castrojo
Copy link
Member

castrojo commented May 8, 2023

Yeah this one is good to go, thanks!

@castrojo castrojo closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants