feat: add adw-gtk3-theme for Silverblue #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reasons: - Users have requested it on Discord and Reddit. - It's an extremely popular and supremely stable (no glitches) theme, which backports LibAdwaita to GTK3 so that your entire GNOME desktop looks uniform. It's completely neutral and simply makes the desktop look good even when app authors haven't updated their old GTK3 apps yet. It makes the waiting more bearable. - It's a requirement of the very popular "Gradience" app, which allows users to apply accent colors to GNOME's Adwaita theme: https://github.com/GradienceTeam/Gradience - It's very tedious to have to manually layer such an essential component for most GNOME users. We simplify the user experience by embedding this small theme. - It's completely opt-in. The user has to manually use GNOME Tweaks to switch to this theme (or use the Gradience app to activate it). - It only belongs in the Silverblue (GNOME) images, since everyone on other Desktop Environments would install GNOME apps via Flatpaks instead, so that they avoid pulling in the entire dependency tree of native GNOME libraries. Therefore, they can get this theme from Flathub instead (since they don't need to theme native apps). - It's fun.
|
I agree with everything, looks good to me. |
castrojo
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Upstream repo: https://github.com/lassekongo83/adw-gtk3)
Reasons:
Users have requested it on Discord and Reddit.
It's an extremely popular and supremely stable (no glitches) theme, which backports LibAdwaita to GTK3 so that your entire GNOME desktop looks uniform. It's completely neutral and simply makes the desktop look good even when app authors haven't updated their old GTK3 apps yet. It makes the waiting more bearable.
It's a requirement of the very popular "Gradience" app, which is endorsed by several GNOME devs and allows users to apply accent colors to GNOME's Adwaita theme: https://github.com/GradienceTeam/Gradience
It's very tedious to have to manually layer such an essential component for most GNOME users. We simplify the user experience by embedding this small theme.
It's completely opt-in. The user has to manually use GNOME Tweaks to switch to this theme (or use the Gradience app to activate it).
It only belongs in the Silverblue (GNOME) images, since everyone on other Desktop Environments would install GNOME apps via Flatpaks instead, so that they avoid pulling in the entire dependency tree of native GNOME libraries. Therefore, they can get this theme from Flathub instead (since they don't need to theme native apps).
It's fun.