Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix inconsistent thumbnails across images #262

Merged
merged 3 commits into from Jun 26, 2023

Conversation

EyeCantCU
Copy link
Member

@EyeCantCU EyeCantCU commented Jun 25, 2023

Addresses an inconsistency where other images can view thumbnails just fine in their respective file managers, but others can't

@fiftydinar
Copy link
Contributor

GTK based DEs work too (tested), so add these too to the list.

Cinnamon doesn't have those in repos, so they need to be built manually.

@castrojo
Copy link
Member

What parts need to be built for Cinnamon?

@fiftydinar
Copy link
Contributor

What parts need to be built for Cinnamon?

ffmpegthumbnailer & raw-thumbnailer.

For LxQT:

ffmpegthumbnailer & qt5-imageformats

@castrojo
Copy link
Member

We should just be able to add them to Cinnamon here right? The two binaries are in the fedora repos already: https://github.com/ublue-os/cinnamon

@fiftydinar
Copy link
Contributor

We should just be able to add them to Cinnamon here right? The two binaries are in the fedora repos already: https://github.com/ublue-os/cinnamon

Yup.

Weirdly, I did not get those packages out of the box, and when I tried to install them in terminal from live-installation, it reported that those packages are not avaliable.

@EyeCantCU
Copy link
Member Author

All right. I'll get this updated. Thank you for the help with this

Addresses RAW thumbnail inconsistency
Kinoite already has ffmpeg thumbnail support
@EyeCantCU EyeCantCU changed the title feat: Include raw-thumbnailer in SB for RAW support in Nautilus feat: Fix inconsistent thumbnails across images Jun 25, 2023
@EyeCantCU
Copy link
Member Author

Opening a PR for Cinnamon as well since it isn't built here

@castrojo castrojo added this pull request to the merge queue Jun 26, 2023
Merged via the queue into ublue-os:main with commit 3fc9c69 Jun 26, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants