Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add WL driver by default (Disabled by default) #350

Merged
merged 1 commit into from
Sep 22, 2023
Merged

feat: Add WL driver by default (Disabled by default) #350

merged 1 commit into from
Sep 22, 2023

Conversation

KyleGospo
Copy link
Member

No description provided.

This was referenced Sep 22, 2023
Merged
Merged
bsherman
bsherman approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Has already been tested out in bazzite, I believe.

@KyleGospo KyleGospo added this pull request to the merge queue Sep 22, 2023
Merged via the queue into main with commit f1a0e1c Sep 22, 2023
59 of 62 checks passed
@KyleGospo KyleGospo deleted the justfile-cleanup branch September 22, 2023 03:55
@github-actions github-actions bot mentioned this pull request Sep 22, 2023
Merged
@szescxz
Copy link

szescxz commented Sep 22, 2023 •
edited

I do get

libkmod: ERROR libkmod/libkmod-config.c:712 kmod_config_parse: /etc/modprobe.d/default-disable-broadcom-wl.conf line 3: ignoring bad line starting with 'wl'

whenever I try to modprobe stuff. Doesn't seem affecting anything but is this the intended behavior?

Because I assumed this should be blacklist wl

@bsherman
Copy link
Contributor

Because I assumed this should be blacklist wl

Thank you! I obviously missed this in my review.

@bsherman bsherman mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsherman bsherman bsherman approved these changes

@castrojo castrojo Awaiting requested review from castrojo castrojo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KyleGospo @szescxz @bsherman