Snapcraft should ensure vendor is of form "Jane Doe <email address hidden>"

[sergiusens]

Snapcraft should ensure vendor is of form "Jane Doe " otherwise click-reviewers-tools will reject it.

Launchpad Details: #LP1510522 Daniel Holbach - 2015-10-27 09:37:10 -0300

[sergiusens]

On Tue, Oct 27, 2015 at 9:37 AM, Daniel Holbach
wrote:

Public bug reported:

Snapcraft should ensure vendor is of form "Jane Doe "
otherwise click-reviewers-tools will reject it.

After talking to beuno, I thought we said we'd fix it in the review tools
instead.

Launchpad Details: #LPC Sergio Schvezov - 2015-10-27 10:06:39 -0300

[sergiusens]

I personally would fix it as early in the process as possible. Let's say you upload a 200M .snap to the store just to find out that you got the email address of the vendor wrong, that would be a bit disappointing, no? Or we could make c-r-t run after the snapcraft build...?

Launchpad Details: #LPC Daniel Holbach - 2015-10-27 10:30:30 -0300

[sergiusens]

Vendor should not be in snapcraft.yaml because that makes it hard to
branch-and-build.

Vendor should be validated by upload tools prior to upload.

Mark

On 27/10/15 22:30, Daniel Holbach wrote:

I personally would fix it as early in the process as possible. Let's say
you upload a 200M .snap to the store just to find out that you got the
email address of the vendor wrong, that would be a bit disappointing,
no? Or we could make c-r-t run after the snapcraft build...?

Launchpad Details: #LPC Mark Shuttleworth - 2015-10-27 19:14:33 -0300

[sergiusens]

There's this question on askubuntu relating directly to this validation:

http://askubuntu.com/questions/417351/what-does-lint-maintainer-format-mean

If we change the behaviour of click-reviewer-tools, we should also update the information there - with Snapcraft, maybe it's already out of date?

Launchpad Details: #LPC James Tait - 2015-10-28 07:17:43 -0300

[sergiusens]

@mark, where would Vendor come from if not from the snapcraft.yaml (which might be the only metadata file that is there imagining all content comes from remote trees) ? only from the store ?

Launchpad Details: #LPC Oliver Grawert - 2015-10-28 08:54:19 -0300

[sergiusens]

~/.snapcraft

It makes more sense to have it as a home-dir config for snapcraft, so
that every snap you build (regardless of where the code came from) shows
up as your vendor.

On the other hand, the snap-id (coming soon) should be in the
snapcraft.yaml because that's the same for everybody who builds it,
typically.

Mark

Launchpad Details: #LPC Mark Shuttleworth - 2015-10-28 18:30:55 -0300

[sergiusens]

For guessing the email we could try to find out DEBEMAIL or bzr whoami, but in some cases, especially for commercial projects, vendor email != individual-maintainer email.

Launchpad Details: #LPC Daniel Holbach - 2015-10-29 05:50:20 -0300

[sergiusens]

i guess then having some kind of "first-start wizard" in place when you use snapcraft for the first time might make sense. to set up the vendor or snap-id and perhaps further global settings that snapcraft will consume (this might be more user friendly than just spilling an error like "please set your vendor ID in ~/.snapcraft")

Launchpad Details: #LPC Oliver Grawert - 2015-10-29 08:38:04 -0300

[come-maiz]

Mark Shuttleworth (sabdfl) wrote 14 hours ago: #9

On 29/10/15 17:50, Daniel Holbach wrote:

For guessing the email we could try to find out DEBEMAIL or bzr whoami, but in some cases, especially for commercial projects, vendor
email != individual-maintainer email.

Please don't guess, just require it to be in ~/.snapcraft and validate
it there. Simpler, cleaner, explicit.

Mark

Mark Shuttleworth (sabdfl) wrote 14 hours ago: #10

In fact, let's make ~/.snapcraft/ a directory:

~/.snapcraft/config
~/.snapcraft/build_key.pem

etc.

Mark

John Lenton (chipaca) wrote 8 hours ago: #11

${XDG_CONFIG_HOME:-$HOME/.config}/snapcraft/ ?

[sergiusens]

We use lp again to track bugs.