Update CONTRIBUTING.md to require a bug. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrofa
force-pushed
the
contributing_require_bug
branch
from
2dd72b8
to
c874d22
Compare
LP: #1532195 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
contributing_require_bug
branch
from
c874d22
to
b16d917
Compare
|
|
||
| 3. Squash commits into one, well-formatted commit. | ||
| 3. Squash commits into one, well-formatted commit. Mention the bug being | ||
| resolved in the commit message on a line all by itself like `LP: #<bug>`. |
There was a problem hiding this comment.
Does it work also making it a link?
There was a problem hiding this comment.
You mean only in the PR instead of the commit? If so, no-- the tools we use for changelog generation parse the commit logs, not the PR descriptions.
There was a problem hiding this comment.
If you mean adding a link to the commit, that also doesn't work since git-dch parses for the LP: #<bug> pattern, which a link wouldn't match.
|
👍 |
|
👍 a link in the PR like @kyrofa does is an added bonus, not sure if necessary, |
|
Agreed. Let's merge this, and if the lack of links becomes painful we can revamp. |
kyrofa
pushed a commit
that referenced
this pull request
Jan 8, 2016
Update CONTRIBUTING.md to require a bug.
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Improved logic to find non-lo interfaces
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Update CONTRIBUTING.md to require a bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves LP: #1532195 by making the first step of the contribution guidelines "Make sure there's a bug."