Always migrate files, even if they already exist. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find your lack of tests disturbing :) |
kyrofa
force-pushed
the
bugfix/1534800/stage_packages_clobbering
branch
from
70d2437
to
5bfb7f5
Compare
|
@ElOpio why, what are you talking about? cough |
|
@kyrofa I think you want something closer to my pastebin |
This prevents files contained in a stage-package .deb from taking precedence over files of the same name produced in the part. The migration is done via hard linking, which means this doesn't add any noticeable delay. LP: #1534800 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/1534800/stage_packages_clobbering
branch
from
5bfb7f5
to
a9777ce
Compare
|
@sergiusens fixed, I believe. |
|
The test looks good to me. I'm not sure if it solves sergio's problem, so I'll leave it for him. |
sergiusens
added a commit
that referenced
this pull request
Jan 16, 2016
…bbering Always migrate files, even if they already exist.
|
👍 |
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…kages_clobbering Always migrate files, even if they already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents files contained in a stage-package .deb from taking precedence over files of the same name produced in the part. The migration is done via hard linking, which means this doesn't add any noticeable delay.
LP: #1534800