Gopasted security override #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LP: #1534784
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
* update loopback detection to use SIOCGIFFLAGS and IFF_LOOPBACK; add unit tests * adds a check for the wireserver ip, and if it does exist then skip the dhcp lookup and route manipulation; adds unit tests * ensure the first selected interface is the primary, which is that with the default route; adds unit tests * parse the wireserver from the dhcp leases file on disk; distro-specific, this is the ubuntu implementation; adds unit tests * unit test fixes, python 3 changes * code review feedback
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
Gopasted security override
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #235