Add usr/bin to the shebang replace path #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 from me, though we may want to do this to all .debs in the future. Just waiting for the tools. |
|
Ah right, the downside to doing it this way: It also needs to be done to the roscore plugin or the file contents differ. |
sergiusens
force-pushed
the
bugfix/1534812/more-shebangs
branch
4 times, most recently
from
5e6bb49
to
b602f5d
Compare
|
I am thinking of rebasing with #236 |
|
Does #236 look good? Feel free to merge and go ahead and rebase. |
| stage: | ||
| - -$dev | ||
| snap: | ||
| - -$dev |
There was a problem hiding this comment.
This makes ROS an awesome example. Cool.
sergiusens
force-pushed
the
bugfix/1534812/more-shebangs
branch
from
b602f5d
to
878d086
Compare
| @@ -298,6 +308,14 @@ def _fix_filemode(path): | |||
| os.chmod(path, mode & 0o1777) | |||
|
|
|||
|
|
|||
| def _fix_shebangs(path): | |||
There was a problem hiding this comment.
It wouldn't hurt to comment why the shebangs have to be fixed. Just like on fix_symlinks above.
sergiusens
force-pushed
the
bugfix/1534812/more-shebangs
branch
from
878d086
to
51c3283
Compare
|
+1 from me. I'm just missing a couple of comments. |
sergiusens
force-pushed
the
bugfix/1534812/more-shebangs
branch
from
51c3283
to
f9066ef
Compare
|
@ElOpio I fixed the code to take into account your comments 😄 |
sergiusens
force-pushed
the
bugfix/1534812/more-shebangs
branch
from
f9066ef
to
cd9c111
Compare
|
@kyrofa done |
sergiusens
added a commit
that referenced
this pull request
Jan 17, 2016
Add usr/bin to the shebang replace path
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
Corrects extension version selection (issue canonical#238). Corrects hanlding of stdout / stderr (issue canonical#260). Signed-off-by: Brendan Dixon <brendand@microsoft.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…shebangs Add usr/bin to the shebang replace path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #1534812