Use docopt to handle example tests arguments. #287
Conversation
|
Looks good to me 👍 . |
| if arguments['--port']: | ||
| tests.config['port'] = arguments['--port'] | ||
| if arguments['--filter']: | ||
| tests.config['filter'] = arguments['--filter'] |
There was a problem hiding this comment.
Is there a problem down under if we just do this:
test.config['ip'] = arguments['--ip']
tests.config['port'] = arguments['--port']
tests.config['filter'] = arguments['--filter']then for test.config you don't need to check for the existence of the key but the key directly i.e. if test.config['filter']
Does this make sense, I have plenty of assumptions in this comment.
There was a problem hiding this comment.
Only the difference between having a dictionary element with None as a value and not having it.
>>> {}.get('port', 22)
22
>>> {'port': None}.get('port', 22)
>>>
I'll make the change to see if you like it better. I slightly prefer to put the complexity here than on the test; but on the other hand it sounds better to handle '', None and unexistin
|
Looks good, but what is test or why is it still running? |
|
test is not running, it was just a test that I could communicate to this PR from jenkins. Now I don't know how to delete it :) |
come-maiz
force-pushed
the
wishlist/1533395/docopt_tests
branch
from
96c2c8f
to
51c66c4
Compare
| @@ -214,14 +214,17 @@ def setUpClass(cls): | |||
| cls.temp_dir = tempfile.mkdtemp() | |||
| if not config.get('skip-install', False): | |||
| ip = config.get('ip', None) | |||
| if ip is None: | |||
| if not ip: | |||
There was a problem hiding this comment.
I like this even if not relevant 😄
LP: #1533395
come-maiz
force-pushed
the
wishlist/1533395/docopt_tests
branch
from
51c66c4
to
8eb9150
Compare
|
So 👍 then |
Use docopt to handle example tests arguments.
…tests Use docopt to handle example tests arguments.
LP: #1533395