Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-tests: add login and logout tests #302

Merged
merged 1 commit into from Feb 9, 2016
Merged

integration-tests: add login and logout tests #302

merged 1 commit into from Feb 9, 2016

Conversation

come-maiz
Copy link
Contributor

No description provided.

@come-maiz come-maiz changed the title Test/upload integration-tests: add login and logout tests Feb 5, 2016
@come-maiz come-maiz mentioned this pull request Feb 5, 2016
Closed
@come-maiz
Copy link
Contributor Author

I get this now. The encrypted env vars are not usable from any pull request. I was assuming that they would be usable from the PRs of members of the team, and that they just could never be printed. Of course, that's totally wrong. So the coveralls token must be a lie, and I spent like a whole week trying to make it work, sooo sad.
Let's keep an eye on travis-ci/travis-ci/issues/1946 to see if they ever enable this.
In the mean time, this login tests will work only for PRs made from the upstream repo, or when running from master.
If you change something that has to do with the login, make sure that your branch is in the upstream repo.

@come-maiz come-maiz mentioned this pull request Feb 5, 2016
Merged
kyrofa
kyrofa reviewed Feb 9, 2016
View reviewed changes
integration_tests/test_login_logout.py
process.expect_exact(
"One-time password (just press enter if you don't use two-factor "
"authentication): ")
process.sendline('')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is nice.

@kyrofa
Copy link
Contributor

kyrofa commented Feb 9, 2016

Yeah, I like it 👍 ! Too bad on the variables, but it makes sense. We'll just need to keep it in mind, I suppose.

kyrofa pushed a commit that referenced this pull request Feb 9, 2016
Merge pull request #302 from ubuntu-core/test/upload
ac24229 
integration-tests: add login and logout tests
@kyrofa kyrofa merged commit ac24229 into master Feb 9, 2016
@come-maiz come-maiz deleted the test/upload branch February 9, 2016 16:11
smoser pushed a commit to smoser/snapcraft that referenced this pull request Sep 14, 2016
@hglkrijger
update agent version to 2.1.5.rc4 (canonical#302)
a48d80d
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
Merge pull request canonical#302 from ubuntu-core/test/upload
16c3aec 
integration-tests: add login and logout tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@come-maiz @kyrofa