New command cleanbuild (using lxd) #328
Conversation
sergiusens
force-pushed
the
feature/1480144/cleanbuild-lxd
branch
from
9ecd308
to
75d8ac7
Compare
|
Hello there, this is I skipped adding an integration test as it seemed way to invasive. |
sergiusens
force-pushed
the
feature/1480144/cleanbuild-lxd
branch
from
75d8ac7
to
aac6ded
Compare
| """ | ||
| snapcraft cleanbuild | ||
|
|
||
| Uses a container using lxd to create the resulting snap. |
There was a problem hiding this comment.
Instead of "Uses a container using lxd", just "Uses a lxd container".
There was a problem hiding this comment.
Maybe also instead of "to create the resulting snap", just "to build the snap".
|
I like this very much. I left many comments just because I'm cranky and want to start my vacations :) |
sergiusens
force-pushed
the
feature/1480144/cleanbuild-lxd
branch
2 times, most recently
from
f214fd3
to
6b1bb6f
Compare
| fn = tarinfo.name | ||
| if fn.startswith('./parts/') and not fn.startswith('./parts/plugins'): | ||
| return None | ||
| elif any(fn == d for d in ('./stage', './snap', tar_filename)): |
There was a problem hiding this comment.
I find fn in ('./stage', './snap', tar_filename) more readable than this
|
👍 |
sergiusens
force-pushed
the
feature/1480144/cleanbuild-lxd
branch
3 times, most recently
from
5e527fb
to
a5f5038
Compare
This new command's intention is to make building with a clean slate and easy chore. LP: #1480144 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
sergiusens
force-pushed
the
feature/1480144/cleanbuild-lxd
branch
from
a5f5038
to
3e3927a
Compare
New command cleanbuild (using lxd)
update agent to 2.1.5
…nbuild-lxd New command cleanbuild (using lxd)
This new command's intention is to make building with a clean
slate and easy chore.
LP: #1480144
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com