Support --debug flag to enable backtrace and debug logs. #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,6 +95,9 @@ def main(): | |||
| try: | |||
| commands.load(args['COMMAND']).main(argv=args['ARGS']) | |||
| except Exception as e: | |||
| if args['--verbose']: | |||
There was a problem hiding this comment.
please let's use --debug for this.
There was a problem hiding this comment.
Ah, I went back and forth on that-- easy peasy.
There was a problem hiding this comment.
Done. Also changed log level.
kyrofa
force-pushed
the
bugfix/1548492/verbose_show_backtrace
branch
from
695c70a
to
fd57ca5
Compare
kyrofa
changed the title
kyrofa
force-pushed
the
bugfix/1548492/verbose_show_backtrace
branch
from
fd57ca5
to
6cccd51
Compare
| args = docopt(__doc__, version=_get_version(), options_first=True) | ||
|
|
||
| cmd = args['COMMAND'] or 'snap' | ||
| if cmd not in _VALID_COMMANDS: | ||
| sys.exit('Command {!r} was not recognized'.format(cmd)) | ||
|
|
||
| # Default log level is INFO unless --debug is specified | ||
| log_level = logging.INFO | ||
| if args['--debug']: |
There was a problem hiding this comment.
--debug won't exist if it is not declared above in the docstring docopt uses.
There was a problem hiding this comment.
Oh for heaven's sake... conflict resolution fail.
kyrofa
force-pushed
the
bugfix/1548492/verbose_show_backtrace
branch
from
6cccd51
to
7c52e52
Compare
| @@ -26,6 +26,7 @@ | |||
| -h --help show this help message and exit | |||
| -v --version show program version and exit | |||
| -V --verbose print additional information about command execution | |||
| -d --debug print debug information while executing (backtraces, etc.) | |||
There was a problem hiding this comment.
maybe (including backtraces) and leave out etc as that can mean anything
|
One comment and we are good 👍 also rebase with |
kyrofa
force-pushed
the
bugfix/1548492/verbose_show_backtrace
branch
from
7c52e52
to
49b3d62
Compare
LP: #1548492 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/1548492/verbose_show_backtrace
branch
from
49b3d62
to
580c43e
Compare
kyrofa
pushed a commit
that referenced
this pull request
Feb 27, 2016
…race Support --debug flag to enable backtrace and debug logs.
smoser
pushed a commit
to smoser/snapcraft
that referenced
this pull request
Sep 14, 2016
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…how_backtrace Support --debug flag to enable backtrace and debug logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves LP: #1548492 by re-raising any caught exception and changing the log level to DEBUG if Snapcraft is running with the
-dor--debugargument.