Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport to 1.x: CMake plugin: Automatically find staged libs and files. #347

Merged
merged 1 commit into from Feb 29, 2016

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Feb 28, 2016

Backport of #345 to 1.x.

@kyrofa kyrofa force-pushed the backport/cmake_find_in_stage branch from dd974f6 to 3510003 Compare February 28, 2016 20:53
@sergiusens
Copy link
Collaborator

snapcraft/tests/test_plugin_cmake.py:107:37: E121 continuation line indentation is not a multiple of four

CMake's find_file(), find_library(), find_package(), and similar
functions use environment variables to determine where to look.
The CMake plugin doesn't utilize these without this commit.

LP: #1550778

Signed-off-by: Kyle Fazzari <kyle@canonical.com>
@kyrofa kyrofa force-pushed the backport/cmake_find_in_stage branch from 3510003 to 449eed3 Compare February 29, 2016 12:35
kyrofa pushed a commit that referenced this pull request Feb 29, 2016
Backport to 1.x: CMake plugin: Automatically find staged libs and files.
@kyrofa kyrofa merged commit c9276c0 into canonical:1.x Feb 29, 2016
@kyrofa kyrofa deleted the backport/cmake_find_in_stage branch February 29, 2016 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants