Expose the invalid build-package on error #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error that results from using an invalid build-package is not very specific. This exposes the KeyError raised by apt. LP: #1547672 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
sergiusens
force-pushed
the
bugfix/1547672/mention-the-package
branch
from
af961a0
to
8bc9e05
Compare
|
Yeah, much better! 👍 |
| 'Could not find all the "build-packages" required in ' | ||
| 'snapcraft.yaml\n') | ||
| "Could not find a required package in 'build-packages': " | ||
| '"The cache has\nno package named \'inexistent-package\'"\n') |
There was a problem hiding this comment.
The newline in here is throwing me. Why is it here and not in the other test below?
There was a problem hiding this comment.
dedent usage in snapcraft.main
sergiusens
added a commit
that referenced
this pull request
Mar 1, 2016
…ckage Expose the invalid build-package on error
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…on-the-package Expose the invalid build-package on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error that results from using an invalid build-package
is not very specific. This exposes the KeyError raised by apt.
LP: #1547672
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com