Support for a daemon's restart-condition #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
| restart-condition: | ||
| type: string | ||
| enum: | ||
| - never |
There was a problem hiding this comment.
The policy, as for daemon is to bring in the exact systemd names
There was a problem hiding this comment.
Which at least according to this is "no," not "never." Right? Or am I reading something wrong?
There was a problem hiding this comment.
I grabbed them from here https://github.com/ubuntu-core/snappy/blob/master/docs/meta.md
So more research is in order
|
Couple minor comments, but looks good 👍 |
sergiusens
force-pushed
the
feature/1552160/support-restart-condition
branch
from
f0e8211
to
7ddcf28
Compare
Just makes it valid syntax in snapcraft.yaml Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
sergiusens
force-pushed
the
feature/1552160/support-restart-condition
branch
from
7ddcf28
to
85384d3
Compare
| - on-failure | ||
| - on-abnormal | ||
| - on-abort | ||
| - always |
There was a problem hiding this comment.
Completely removing the "no?"
There was a problem hiding this comment.
Yes for now snapcore/snapd#567
sergiusens
added a commit
that referenced
this pull request
Mar 3, 2016
…rt-condition Support for a daemon's restart-condition
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
…ort-restart-condition Support for a daemon's restart-condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just makes it valid syntax in snapcraft.yaml
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com