Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain the new way to provide snap icons. #409

Merged

Conversation

sergiusens
Copy link
Collaborator

LP: #1561327

Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.884% when pulling 463349b on sergiusens:bugfix/1561327/icon-in-setup into 1b15b6a on ubuntu-core:master.


To provide an icon for your snap, while for command line applications might
not seem as important it is rather important for discoverability from
management interfaces such as store fronts like webdm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could flow a bit better. Perhaps something like "Providing an icon for your snap is important, even for command-line applications, if for nothing else than discoverability from management[...]"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

LP: #1561327

Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
@come-maiz
Copy link
Contributor

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.884% when pulling d460d9d on sergiusens:bugfix/1561327/icon-in-setup into 1b15b6a on ubuntu-core:master.

@kyrofa
Copy link
Contributor

kyrofa commented Mar 29, 2016

👍

@sergiusens sergiusens merged commit 4073f89 into canonical:master Mar 29, 2016
@sergiusens sergiusens deleted the bugfix/1561327/icon-in-setup branch August 30, 2016 16:55
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Apr 6, 2017
…in-setup

Explain the new way to provide snap icons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants