Use colors for logging. #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the following colors: - INFO: Green - WARNING: Yellow - ERROR: Dark red - CRITICAL: Light red LP: #1572186 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kyrofa
force-pushed
the
bugfix/1572186/use_colors
branch
from
c38c19a
to
9dd8a2e
Compare
kyrofa
force-pushed
the
bugfix/1572186/use_colors
branch
from
174329e
to
cebccb5
Compare
| '\x1b[1m' | ||
| 'Login {}.'.format(result) + | ||
| '\x1b[0m\r\n') | ||
| process.expect_exact('Login {}.'.format(result)) | ||
|
|
||
| def logout(self): | ||
| output = self.run_snapcraft('logout') |
There was a problem hiding this comment.
This is a lot better, thanks.
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
|
👍 |
kyrofa
force-pushed
the
bugfix/1572186/use_colors
branch
from
cebccb5
to
cd7ad9c
Compare
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
This uses the following colors: - INFO: Green - WARNING: Yellow - ERROR: Dark red - CRITICAL: Light red LP: #1572186 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes LP: #1572186 by using the following colors: