Create Plainbox Provider plugin #609
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
acde73b
to
2a8de9d
Compare
|
ok to test |
| super().__init__(name, options, project) | ||
| self.build_packages.extend(['python3-plainbox', 'intltool']) | ||
| if self.options.checkbox_dev_ppa: | ||
| self._PLUGIN_STAGE_SOURCES = self._DEV_PPA_PLUGIN_STAGE_SOURCES |
There was a problem hiding this comment.
@jocave is there any chance of just grabbing plainbox/checkbox from pypi?
I am working on a plugin that uses the core python. Maybe in the future you can inherit from that and produce nimbler snaps
There was a problem hiding this comment.
@sergiusens IIRC the version of plainbox in pypi doesn't have the support for snappy layouts that we need.
There was a problem hiding this comment.
I actually think it makes sense to try and remove the expectation that a provider part pulls plainbox/checkbox in to its stage-packages as the goal is to pull multiple re-usable providers in to a snap.
As checkbox snap with one separate part that pulls plainbox/checkbox-ng from pypi would therefore make sense and it could use the python3 plugin.
The thing I'm less clear whether the allows us to be sure we are getting a compatible version of the build dependency - python3-plainbox
|
I'm going to rework things slightly and post a new version, hopefully we can work out a way to not have to use the dev ppa |
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
2a8de9d
to
20dfdf2
Compare
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
20dfdf2
to
518e102
Compare
|
@sergiusens with the landing of python3 plugin to use --root we can now pull all the plainbox/checkbox dependencies from pypi. As a result I've removed the need for the modified source repositories and the plugin should be a bit cleaner :) HTH |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
retest this please |
1 similar comment
|
retest this please |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
ok to test |
|
retest this please |
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
518e102
to
6ba7c1f
Compare
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
| expected) | ||
| # check can run the tests in the example provider | ||
| self.run_command_in_snappy_testbed( | ||
| '/snaps/bin/plainbox-test-tool.plainbox run -i 2016.com.example::.*') |
There was a problem hiding this comment.
The path is in /snap/bin, not snaps.
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
6ba7c1f
to
b227a7d
Compare
|
Can one of the admins verify this patch? |
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
b227a7d
to
a217162
Compare
|
The demo is currently failing to run as expected. This seems to have been as a result of the switch to getting plainbox from pypi. Still investigating.. |
lp: #1552369
jocave
force-pushed
the
plainbox-provider-plugin
branch
from
a217162
to
4d897c3
Compare
|
retest this please |
|
The last problem was just a missing python-package dependency in the demo snap. |
LP: #1552369
lp: #1552369
Integration tests provided that check the plugin can be
used in several common Checkbox use cases.