Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced the double quotes by single quotes on strings. #65

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

come-maiz
Copy link
Contributor

Closes #25.
Consistency ftw!

@ted-gould
Copy link
Contributor

Looks straight forward to me. Would love to know where that 0.2% coverage went :-)

@dholbach
Copy link
Contributor

dholbach commented Nov 2, 2015

I'm not quite sure what happened, but https://coveralls.io/files/1403916637 is pointed out as having less coverage. The changes generally look good to me.

@sergiusens
Copy link
Collaborator

I think we need to stop running the plainbox tests in coverage mode.

sergiusens added a commit that referenced this pull request Nov 2, 2015
Replaced the double quotes by single quotes on strings.

Closes #25.
@sergiusens sergiusens merged commit 06c8a88 into canonical:master Nov 2, 2015
@come-maiz come-maiz deleted the quotes branch November 2, 2015 13:33
@come-maiz
Copy link
Contributor Author

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2015-11-02 04:56, sergiusens wrote:

I think we need to stop running the plainbox tests in coverage
mode.

I don't mind not reporting to coveralls the plainbox coverage.

But I think we need to add a test for autotools. That might solve two
problems, the weird coverage result and the uncovered module.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWOW/ZAAoJEIUvYw0No8DgwZsP/jtk5VKzZUWrE6UreaHTKjJl
Uf+8Z0R96CfQju11Yr/0jaOTiu4KqlhjopZXzvVMrpNO7ZCr8CaGuwHqerjm77zu
B9a1DHLjmLYDwFa1HQd72nwc4oPtralbXzOnw9lip5t6pQruAfEUKRZEltZrMdt1
2JhKBScGwEq5CdetiENfdu+qrPjQAdhbpXSgSWznXrx2Nj/Afcg7BQHx+v9jqgmw
xnKAePBxEx+TYWqxVpwWFYxFsdDlL6+wnXFNIk0h2UMqAIBj2EmbO69Gz/XN/RSX
Y6+DO0YXYb8mdJmMU+aReGA7ph83kvBa1HujHgmGU51fjnxdHl53iUn3IGx0xVJw
4V5sBojx351hVWHYoixI9mPryCls+tWMwBb9IWlShxAQWjvfl3HkmbGph3NWP5Nl
2AaY+xbOKlwor2oPXL9vR7sOcfikgPOSYifxODaLmT2g5bogffaB2Nd7+p15pH2J
30861rCA+fu7QdS6XXLXK1Ds/Um28HxcNHbEUxzZe4puFyvSJlA0/mrjt6YKzX+W
sWByDQvWIUOXnEKQrpkQVLnopsqj38wSoDhRLaASNpZCOJbTlp+xkxb10p9PgifY
/dN7xHOZvLJJM/WvhmPi8/844UDkyVWB31pL7pRROAnewiDCbvaJGYHZP2+a0BKm
a8XGVGqpclHVHfTGx426
=NHqz
-----END PGP SIGNATURE-----

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants