Shorter manifest #74
Closed
Shorter manifest #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apcraft that is in the repo
…n I could know that could happen. For a friend.
| debianutils | ||
| diffutils | ||
| dmsetup | ||
| dpkg |
There was a problem hiding this comment.
do we need this included in snaps?
There was a problem hiding this comment.
On Tue, 2015-11-03 at 16:52 -0800, sergiusens wrote:
In snapcraft/manifest.txt:
dash
-debconf
-debconf-i18n
-debianutils
-diffutils
-dmsetup
-dpkg
do we need this included in snaps?
I was thinking for people who may use things like dpkg-archiecture to
setup an environment variable. I'd like to find a way to not include it
unless they're using it explicitly, but I don't see a way to do that.
Perhaps we could filter it by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortening the manifest so that snap packages have more of their own stuff. Basically making less assumptions on the platform. I've also made a small shell script to build all the examples and attached the output. I don't see anything odd, but reviewers should check my work ;-)
$ find . -name "*snap" | xargs -n 1 du -h
868K ./godd/godd_1.0_amd64.snap
240K ./downloader-with-wiki-parts/downloader_1.0_amd64.snap
4.0M ./gopaste/gopaste_1.0_amd64.snap
55M ./py2-project/spongeshaker_0_amd64.snap
90M ./webcam-webui/webcam-webui_1_amd64.snap
185M ./tomcat-maven-webapp/tomcat-webapp-demo_1.0_amd64.snap
139M ./qmldemo/qmldemo_1_amd64.snap
86M ./py3-project/spongeshaker_0_amd64.snap
189M ./ros/ros-example_1.0_amd64.snap
176M ./java-hello-world/java-hello-world_0_amd64.snap
72K ./libpipeline/pipelinetest_1.0_amd64.snap
run.txt