Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some parts of App Center do not scale text correctly with "Large Text" mode enabled #1403

Open
shytzedaka opened this issue Sep 25, 2023 · 12 comments
Labels
Accessibility Accessibility, Usability, and Inclusion considerations bug jira Sync with JIRA

Comments

@shytzedaka
Copy link

When using the accessibility mode "Large Text" as presented here:
image
or using the terminal command to get the same effect:
gsettings set org.gnome.desktop.interface text-scaling-factor 1.25

Text does not appear to be extending or scaling in some areas of the App Center as can be seen here:
image

it appears the issue only occurs at the sidebar of the app center and not the rest of the program.
Note: I am Using a 1920x1080 Display with regular 100% scale and the App Center is fully maximized
image

@d-loose d-loose added bug Accessibility Accessibility, Usability, and Inclusion considerations jira Sync with JIRA labels Sep 25, 2023
@d-loose
Copy link
Member

d-loose commented Sep 25, 2023

Thanks for the screenshots!
We definitely need to improve the spacing in some places to accommodate larger fonts. A few more screenshots (with ratings backend running):

Normal Font Large Font
Screenshot from 2023-09-25 13-56-22 Screenshot from 2023-09-25 13-56-14
Screenshot from 2023-09-25 13-57-48 Screenshot from 2023-09-25 13-58-02

@anaserejio: something to look at when you got time :)

@anorld-droid
Copy link

anorld-droid commented Oct 6, 2023

@d-loose I have improved the spacings.
Screenshot from 2023-10-06 11-01-21
Screenshot from 2023-10-06 11-01-42
Screenshot from 2023-10-06 11-22-01

Should I send a PR, you check it out?

@d-loose
Copy link
Member

d-loose commented Oct 6, 2023

@d-loose I have improved the spacings.

Thanks - looks great! I'm wondering if there's enough space for the ratings though. Can you check what it looks with the ratings enabled?

RATINGS_SERVICE_URL=ratings.ubuntu.com flutter run

@d-loose
Copy link
Member

d-loose commented Oct 6, 2023

What is the expected outcome for this, should we increase it's width? https://user-images.githubusercontent.com/113362648/270333836-c626f3e7-0a5d-4bf0-b74a-cf223311ba09.png

I don't know yet, we'll need to patiently wait for @anasereijo, who works on the design for the app center.

@anorld-droid
Copy link

anorld-droid commented Oct 6, 2023

@d-loose I have improved the spacings.

Thanks - looks great! I'm wondering if there's enough space for the ratings though. Can you check what it looks with the ratings enabled?

RATINGS_SERVICE_URL=ratings.ubuntu.com flutter run

Yeah, not so good. We may have to increase the height of the card to accommodate the summary;it has a maxlines of 2 OR make its maxlines to 1.

What do you think, @d-loose?

image

@anasereijo
Copy link
Collaborator

Hi @shytzedaka, thank you for filling the issue. We are planning on doing an accessibility assessment on the app, but in the meantime, feel free to file any issues or propose improvements. :)

@anorld-droid thanks for doing this 🙌 one question: are you changing the height of the cards when Large text is enabled or for both situations (enabled and disabled)?

@anorld-droid
Copy link

Hi @shytzedaka, thank you for filling the issue. We are planning on doing an accessibility assessment on the app, but in the meantime, feel free to file any issues or propose improvements. :)

@anorld-droid thanks for doing this 🙌 one question: are you changing the height of the cards when Large text is enabled or for both situations (enabled and disabled)?

Both, but I will add when Large text is enabled; I had not thought of that.

@shytzedaka
Copy link
Author

shytzedaka commented Nov 4, 2023

hey! it seems that this bug so far persists in released Ubuntu 23.10.1 (Clean install of the latest public ISO)
I'm not sure if this is still being fixed or not but i thought it would be worth pointing that out since we're out of the beta phase.

image

@olekzonder
Copy link

Text does not scale with other languages like Russian, where the word meaning Manage ("Управление") or About ("Об App Center") are too big to fit and get cut off by dots.

I don't think it looks right. I'm using the Snap Store from the Edge channel.

@shytzedaka
Copy link
Author

shytzedaka commented May 22, 2024

Is there an update on this?

@d-loose
Copy link
Member

d-loose commented May 23, 2024

We'll have some time for polishing and bug fixing this cycle and also plan to do some refactoring :). While a lot of accessibility issues need to be fixed in the Flutter embedder, this issue is simply caused by an inflexible implementation of the layout and can/should be fixed here.

@shytzedaka
Copy link
Author

Thank you for your hard work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Accessibility, Usability, and Inclusion considerations bug jira Sync with JIRA
Projects
None yet
Development

No branches or pull requests

5 participants