-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number of search-results to category dropdown #557
Comments
I fear this is not possible without decreasing performance. You can search with given category or none. This would require one search for each category (21) for each letter you type. This will def. decrease performance. I am not sure if this is worth it 🤔 |
What we can do out of the box, is to display the number for search results in the dropdown button |
Makes sense
Well, there's no need to update it as the user is typing. You can't type and click the dropdown at the same time, so there's a delay from when the user stops typing and then opens the dropdown. The "closed" dropdown should not list the number of results, only when opened. Would this still be a too demanding task to do? |
Another problem: the categories only affect snaps We can keep this open but this won't happen any time soon |
Let's not 😊 thanks for answering all the questions |
Ok! :) |
I proposed the same thing as @madsrh here. I also believe it would be helpful for the user to know how many results they can find on each category. Displaying the items that have no results (with the zero and greyed out) it is a good usability practice — provides a first level of feedback and prevents the user wondering what happened to the other categories. Always better to display instead of hiding choices. |
@madsrh I really like the use of icons on the dropdown 👌 |
@anasereijo this screenshot is outdated it now says "All snap categories" classic packages/debian packages do not follow those categories for snaps. As written some comments up https://github.com/ubuntu-flutter-community/software/issues/560 As always I must be the performance police 👮♂️ |
Snaps: when you search on the snap store, you can request fields, such as category – is it not possible to calculate the number of packages in each category on the frontend based on this field, no additional requests needed? Also for the snap store, we can file a ticket to ask that the response returns category counts. It might not happen immediately, but it keeps this open for the future. Debs: It's true we need to map the snap category → group, but we have that already @robert-ancell should be able to help there. Edit: Just seen your linked issue to the mapping :) |
Yes, we use the category feature already. But it just returns a list of snaps. |
Launchpad issue for tracking: https://bugs.launchpad.net/snapstore-server/+bug/1998482 |
The text was updated successfully, but these errors were encountered: