Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window title bar vs. debug banner #536

Closed
jpnurmi opened this issue Jan 17, 2023 · 6 comments
Closed

Window title bar vs. debug banner #536

jpnurmi opened this issue Jan 17, 2023 · 6 comments
Labels
question Further information is requested

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Jan 17, 2023

Not sure if there's anything we can do to control the banner location but it's a bit annoying that it goes now over the window controls by default:

image
@d-loose
Copy link
Member

d-loose commented Jan 17, 2023

It's time to define YaruApp with its own custom debug banner!

@Feichtmeier
Copy link
Member

We could copy the gnomies and add some fancy 💀 🚧 pattern with opacity to the headerbar :P

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 20, 2023

YaruApp would have to forward a painful amount of arguments to MaterialApp constructors but it would definitely help us to fix a bunch of things like the debug banner and also to ensure the correct background color (GTK window vs. Yaru Scaffold)...

image

@jpnurmi
Copy link
Member Author

jpnurmi commented Feb 25, 2023

I documented the workaround in:

@Feichtmeier
Copy link
Member

@d-loose is this still an issue or is the work around enough? (I always turn those off xd)

@Feichtmeier Feichtmeier added the question Further information is requested label Mar 3, 2024
@d-loose
Copy link
Member

d-loose commented Mar 4, 2024

Personally, I'm perfectly fine with the workaround

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpnurmi @Feichtmeier @d-loose