Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide legacy, full color action icons #1965

Closed
18 of 58 tasks
Feichtmeier opened this issue Feb 22, 2020 · 28 comments · Fixed by #2371
Closed
18 of 58 tasks

Provide legacy, full color action icons #1965

Feichtmeier opened this issue Feb 22, 2020 · 28 comments · Fixed by #2371

Comments

@Feichtmeier
Copy link
Member

Feichtmeier commented Feb 22, 2020

Those icons are visible in Inkscape, they are ofc visible somewhere else, but since it is such a popular app, I think this is a very solid goal and the actual icons to draw are not so many:

image

  • edit-redo (icon)
  • redo (symlink)
  • gtk-redo-ltr (symlink)
  • stock_redo (symlink)

image

  • edit-undo (icon)
  • undo (symlink)
  • gtk-undo-ltr (symlink)
  • stock_undo (symlink)

image

  • go-up (icon)
  • up (symlink)
  • gtk-go-up (symlink)
  • stock_up (symlink)

image

  • go-down (icon)
  • down (symlink)
  • gtk-go-down (symlink)
  • stock_down (symlink)

image

  • go-bottom (icon)
  • bottom (symlink)
  • gtk-goto-bottom (symlink)
  • stock_bottom (symlink)

image

  • go-top (icon)
  • top (symlink)
  • gtk-goto-top (symlink)
  • stock_top (symlink)

image

  • edit-copy (icon)
  • editcopy (symlink)
  • gtk-copy (symlink)
  • stock_copy (symlink)

image

  • edit-paste (icon)
  • editpaste (symlink)
  • gtk-paste (symlink)
  • stock_paste (symlink)

image

  • edit-cut (icon)
  • editcut (symlink)
  • gtk-cut (symlink)
  • stock_cut (symlink)

image

  • document-properties (icon)
  • gtk-properties (symlink)
  • stock_file-properties (symlink)
  • stock_properties (symlink)

image

  • gconf-editor (icon)
  • gconfeditor (symlink)
  • administration (symlink)
  • control-center2 (symlink)
  • drakconf (symlink)
  • gkdebconf (symlink)
  • gkdebconf-icon (symlink)
  • gnome-desktop-config (symlink)
  • paprefs (symlink)

image

  • rotate (icon)
  • object-rotate-left (icon)
  • object-rotate-right (icon)

image

  • object-flip-vertical (icon)
  • object-flip-horizontal (icon)

image

  • zoom-in (icon)
  • zoom-out (icon)
  • zoom-fit-best (icon)
  • zoom-original (icon)
@Feichtmeier Feichtmeier added this to Backlog in Yaru via automation Feb 22, 2020
@madsrh
Copy link
Member

madsrh commented Feb 22, 2020

Do you still think the arrows should be orange? 🤔

IMHO the zoom icons are a higher priority since the Adwaita decided to update only 4 of the zoom icons. This adwaita doesn't fit well with Humanity or Yaru. Also the Humanity 🔍 magnifier icon isn't great in the dark theme.

image

@Feichtmeier
Copy link
Member Author

I'll add them to the list.
You can prioritize them as you want, since I can not help drawing. :)
I also found other rotate icons which I will add to the list.

@gusbemacbe
Copy link
Contributor

Hello everybody!

Sorry for my long absence. Since my grandparents travelled, I have been overcharged with homeworks as feeding and taking care of their pet, cleaning and taking care of their house.

@Bonandry redesigned some legacy icons I was analysing in his beta repository.

@Bonandry, hai tempo per ridisegnare le icone legate? Guarda alle icone sopra.

@Feichtmeier
Copy link
Member Author

Hi @gusbemacbe
That would be very cool!

We would love to see them colored though, since the gnome toolkit requests them to be full colored, or better: they don't expect them to be symbolic icons. Would this be possible for you two guys?

@gusbemacbe
Copy link
Contributor

Yes, he did coloured legacy icons, I will show his icons.

@gusbemacbe
Copy link
Contributor

Hey, everybody, @Bonandy is doing these icons now. We must be waiting.

@gusbemacbe
Copy link
Contributor

gusbemacbe commented Feb 23, 2020

Here are the previews of legacy icons in some apps which are using legacy icons, made by @Bonandry, and check Evolution, Inkscape and Transmission

  • Solitary

Solitario

  • Asunder

imageAsunder

  • Evolution

Evolution

  • Evolution Send

Evolution Send

  • Bleachbit

Bleachbit

  • GParted

GParted

  • Inkscape

Inkscape

  • Keepass

Keepass

  • Meld

Meld

  • Synpatic

SYnpatic

  • Transmission

Transmission

@Feichtmeier
Copy link
Member Author

Awesome! We're looking forward to this. Do you guys need help with the pull requests?

@gusbemacbe
Copy link
Contributor

@Bonandry does not know anything about GitHub. Only I know. He will send the pack to me and I will reconfigure it. But if you want his ready pack, we will send to you.

@gusbemacbe
Copy link
Contributor

Hello @Feichtmeier and @madsrh

Here is his pack:
legacy-icons.zip

@Bonandry forgot some icons. I will send some missed icons to him.

@gusbemacbe
Copy link
Contributor

@Feichtmeier and @madsrh

Here are missed legacy icons:
missed-legacy-icons.zip

@gusbemacbe
Copy link
Contributor

Hello @Feichtmeier and @madsrh again !

Here is another alternative icon of legacy zoom icons: alternative-legacy-zoom.zip

@Feichtmeier
Copy link
Member Author

@gusbemacbe @Bonandry absolutely amazing thank you 🎉

"We" try to get them in for 20.04 - and will ofc credit to you guys! Thank you very much!

@ubuntujaggers
Copy link
Contributor

ubuntujaggers commented Feb 24, 2020

@gusbemacbe @Bonandry Thanks very much for these, this is a heroic effort!

Unfortunately we've decided to back away from providing full colour legacy actions in the theme (including removing the small number of ones we already had).

Basically, these icons were originally out of scope for Yaru, but we encountered a problem where some of the buttons in older apps were getting replaced by a similarly named but wrong Yaru icon (example: various document-* buttons, like "save" and "new", all getting replaced by the same generic document from Yaru).

We responded by providing Yaru icons with the correct legacy name and a suitable metaphor, although ours weren't brilliant. We've now worked out how to make it so the Yaru icons don't replace the Humanity ones in the first place.

If we include our own icons here, the likely result will be a mix of styles in apps like Inkscape (because the Inkscape-specific buttons will have the old style and ones that are common across apps, like document-new, document-save, will have a different one - EDIT: unless we theme the Inkscape ones too, but there will always be other affected apps). Now we can make the original problem go away, it's safer for Yaru to just leave the legacy actions alone. Luckily people still have the option of Yaru++ 👍

Thanks for sharing these files and I'm looking forward to your future contributions (e.g., don't hold back if you can suggest improvements to our existing icons!).

@gusbemacbe
Copy link
Contributor

gusbemacbe commented Feb 25, 2020

Hello @ubuntujaggers!

@gusbemacbe @Bonandry Thanks very much for these, this is a heroic effort!

You are welcome

Unfortunately we've decided to back away from providing full colour legacy actions in the theme (including removing the small number of ones we already had).

Now we can make the original problem go away, it's safer for Yaru to just leave the legacy actions alone. Luckily people still have the option of Yaru++ 👍

Too bad, no problems. Yaru++ will include the modern and new legacy icons. @Bonandry redesigned the Inkscape tools icons:

Inkscape

@meetdilip
Copy link

@gusbemacbe If you have made almost the full palette of icons, consider releasing them as Inkscape icon pack. That way Inkscape users will have another option and your hard work will be put into use as well.

@Feichtmeier
Copy link
Member Author

@gusbemacbe did he really made the full set of inkscape icons? Could you share a new, complete zip?

@gusbemacbe
Copy link
Contributor

@meetdilip, great tip!

@Feichtmeier, no, but here are some icons:
inkscape.zip

@madsrh
Copy link
Member

madsrh commented Feb 25, 2020

As much as we all love Inkscape and know that it really could use some more modern icons, I don't think we should change these, because Inkscape ships with Adwaita icons on the Windows (and OSX I think) version.
IMO the best solution would be to approach upstream and ask if they would be interested in a dedicated Inkscape theme 🤷‍♂️

@meetdilip
Copy link

They allow it. Even have a showcase for it. But yes, a word with them will be nice.

https://inkscape.org/gallery/=inkscape-gui-icon-set/

I think I posted this and it got deleted. Or it is 12 am and I am too sleepy.

@Feichtmeier
Copy link
Member Author

Nice!

https://inkscape.org/~m1981/%E2%98%85icons-inkscape+2
"An iconset to revamp Inkscape main tools."

Future is bright! Okay, then I think we can close this issue here.
But I still think we should keep at least the folder icon, the ✔️ for Ubitquity - WDYT @ubuntujaggers ?

@ubuntujaggers
Copy link
Contributor

Nice!

https://inkscape.org/~m1981/%E2%98%85icons-inkscape+2
"An iconset to revamp Inkscape main tools."

Future is bright! Okay, then I think we can close this issue here.
But I still think we should keep at least the folder icon, the for Ubitquity - WDYT @ubuntujaggers ?

Is the folder icon also used in Ubiquity?

@Feichtmeier
Copy link
Member Author

No but everywhere else in gtk2 or old gtk3 apps. Otherwise there is an orange folder showing up

@Feichtmeier
Copy link
Member Author

Keeping this opened to check if we've have all icons and see if we could optimize it with symlinks even if #2002 has been merged
Thanks to @ubuntujaggers for raging through the icons and thanks to @gusbemacbe and @Bonandry for providing us a very solid foundation!

@Feichtmeier Feichtmeier changed the title Provide legacy, full color action icons for Inkscape Provide legacy, full color action icons May 25, 2020
@Feichtmeier
Copy link
Member Author

Status update: we decided to drop those for 20.04 because they were incomplete.
I think no decision has been made here yet, let's see.

@Feichtmeier
Copy link
Member Author

@Jupiter007-43 could you reuse any of the many libre office full colour icons you've made for this full colour action icons here?

@Jupi007
Copy link
Member

Jupi007 commented Sep 27, 2020

@Jupiter007-43 could you reuse any of the many libre office full colour icons you've made for this full colour action icons here?

Of course. Which icons are missing?

@Feichtmeier
Copy link
Member Author

The list is at the top but I'm not sure if it's complete and I'm not sure which of those icons are handled in @ubuntujaggers 's new PR :) I guess only Stuart knows

@Feichtmeier Feichtmeier moved this from Backlog to To Do - 30.04 in Yaru Oct 7, 2020
@Feichtmeier Feichtmeier moved this from To Do - 30.04 to In progress in Yaru Oct 7, 2020
Yaru automation moved this from In progress to Done Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Yaru
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants