-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide legacy, full color action icons #1965
Comments
Do you still think the arrows should be orange? 🤔 IMHO the zoom icons are a higher priority since the Adwaita decided to update only 4 of the zoom icons. This adwaita doesn't fit well with Humanity or Yaru. Also the Humanity 🔍 magnifier icon isn't great in the dark theme. |
I'll add them to the list. |
Hello everybody! Sorry for my long absence. Since my grandparents travelled, I have been overcharged with homeworks as feeding and taking care of their pet, cleaning and taking care of their house. @Bonandry redesigned some legacy icons I was analysing in his beta repository. @Bonandry, hai tempo per ridisegnare le icone legate? Guarda alle icone sopra. |
Hi @gusbemacbe We would love to see them colored though, since the gnome toolkit requests them to be full colored, or better: they don't expect them to be symbolic icons. Would this be possible for you two guys? |
Yes, he did coloured legacy icons, I will show his icons. |
Hey, everybody, @Bonandy is doing these icons now. We must be waiting. |
Here are the previews of legacy icons in some apps which are using legacy icons, made by @Bonandry, and check Evolution, Inkscape and Transmission
|
Awesome! We're looking forward to this. Do you guys need help with the pull requests? |
@Bonandry does not know anything about GitHub. Only I know. He will send the pack to me and I will reconfigure it. But if you want his ready pack, we will send to you. |
Hello @Feichtmeier and @madsrh Here is his pack: @Bonandry forgot some icons. I will send some missed icons to him. |
@Feichtmeier and @madsrh Here are missed legacy icons: |
Hello @Feichtmeier and @madsrh again ! Here is another alternative icon of legacy zoom icons: alternative-legacy-zoom.zip |
@gusbemacbe @Bonandry absolutely amazing thank you 🎉 "We" try to get them in for 20.04 - and will ofc credit to you guys! Thank you very much! |
@gusbemacbe @Bonandry Thanks very much for these, this is a heroic effort! Unfortunately we've decided to back away from providing full colour legacy actions in the theme (including removing the small number of ones we already had). Basically, these icons were originally out of scope for Yaru, but we encountered a problem where some of the buttons in older apps were getting replaced by a similarly named but wrong Yaru icon (example: various document-* buttons, like "save" and "new", all getting replaced by the same generic document from Yaru). We responded by providing Yaru icons with the correct legacy name and a suitable metaphor, although ours weren't brilliant. We've now worked out how to make it so the Yaru icons don't replace the Humanity ones in the first place. If we include our own icons here, the likely result will be a mix of styles in apps like Inkscape (because the Inkscape-specific buttons will have the old style and ones that are common across apps, like document-new, document-save, will have a different one - EDIT: unless we theme the Inkscape ones too, but there will always be other affected apps). Now we can make the original problem go away, it's safer for Yaru to just leave the legacy actions alone. Luckily people still have the option of Yaru++ 👍 Thanks for sharing these files and I'm looking forward to your future contributions (e.g., don't hold back if you can suggest improvements to our existing icons!). |
Hello @ubuntujaggers!
You are welcome
Too bad, no problems. Yaru++ will include the modern and new legacy icons. @Bonandry redesigned the Inkscape tools icons: |
@gusbemacbe If you have made almost the full palette of icons, consider releasing them as Inkscape icon pack. That way Inkscape users will have another option and your hard work will be put into use as well. |
@gusbemacbe did he really made the full set of inkscape icons? Could you share a new, complete zip? |
@meetdilip, great tip! @Feichtmeier, no, but here are some icons: |
As much as we all love Inkscape and know that it really could use some more modern icons, I don't think we should change these, because Inkscape ships with Adwaita icons on the Windows (and OSX I think) version. |
They allow it. Even have a showcase for it. But yes, a word with them will be nice. https://inkscape.org/gallery/=inkscape-gui-icon-set/ I think I posted this and it got deleted. Or it is 12 am and I am too sleepy. |
Nice! https://inkscape.org/~m1981/%E2%98%85icons-inkscape+2 Future is bright! Okay, then I think we can close this issue here. |
Is the folder icon also used in Ubiquity? |
No but everywhere else in gtk2 or old gtk3 apps. Otherwise there is an orange folder showing up |
Keeping this opened to check if we've have all icons and see if we could optimize it with symlinks even if #2002 has been merged |
Status update: we decided to drop those for 20.04 because they were incomplete. |
@Jupiter007-43 could you reuse any of the many libre office full colour icons you've made for this full colour action icons here? |
Of course. Which icons are missing? |
The list is at the top but I'm not sure if it's complete and I'm not sure which of those icons are handled in @ubuntujaggers 's new PR :) I guess only Stuart knows |
Those icons are visible in Inkscape, they are ofc visible somewhere else, but since it is such a popular app, I think this is a very solid goal and the actual icons to draw are not so many:
The text was updated successfully, but these errors were encountered: