Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some missing mimetype icons #2334

Open
8 of 30 tasks
madsrh opened this issue Aug 30, 2020 · 31 comments
Open
8 of 30 tasks

Some missing mimetype icons #2334

madsrh opened this issue Aug 30, 2020 · 31 comments
Assignees
Projects

Comments

@madsrh
Copy link
Member

madsrh commented Aug 30, 2020

Here's a few more mimetype icons we can add if anyone want's something to work on :) Some of these are pretty rare or even legacy, so here's a list to pick from in no particular order.
Most of these can be tested with the files here.

@Jupi007
Copy link
Member

Jupi007 commented Aug 30, 2020

😳 There is a lot!
I'll think about them tomorrow.

@ubuntujaggers I think there's plenty of work for two. 😋

@madsrh
Copy link
Member Author

madsrh commented Aug 30, 2020

I know 😅 Again, some of these are pretty crazy. We can add a 30.04 tag?

@Feichtmeier
Copy link
Member

Feichtmeier commented Aug 31, 2020

We can just add it to backlog 🤷
And you use this issue to manage individual issues and manage the ToDo list.
I would then create an issue for each individual icon and link them to the ToDo list entries.
PR's can have multiple Closes #123142342XYZ but for issues I would really stick to 1 icon 1 issue to handle it easier.

@Muqtxdir
Copy link
Member

Muqtxdir commented Oct 13, 2020

hi,
could we also add text/x-xmi to the list as well ?

@madsrh
Copy link
Member Author

madsrh commented Oct 13, 2020

hi, could we also add text/x-xmi to the list as well ?

OFC @Muqtxdir ! Can you edit the list yourself? Feel free to add more, if you come across any thing we're missing

@Muqtxdir
Copy link
Member

Muqtxdir commented Oct 13, 2020

OFC @Muqtxdir ! Can you edit the list yourself? Feel free to add more, if you come across any thing we're missing

umm, i don't think I have the permission to edit

@Muqtxdir
Copy link
Member

also add application/x-r-project to the list from #2374 😅 (I forgot to mention that)

@Jupi007
Copy link
Member

Jupi007 commented Oct 15, 2020

I also added the application/x-msdownload (.dll) mimetype to the list:

Capture d’écran du 2020-10-15 12-20-29

@stuarthayhurst
Copy link
Contributor

Would symlinking application/x-msdownload to the icon for application/x-mswinurl work?

@Jupi007
Copy link
Member

Jupi007 commented Dec 10, 2020

Would symlinking application/x-msdownload to the icon for application/x-mswinurl work?

I don't think so, this icon symbolize a link or an url.
IMO we should use the application-octet-stream icon as dlls are binaries files.

@stuarthayhurst
Copy link
Contributor

I made 2 mimetype icons for my icon theme in Yaru's style and was wondering if anyone wants them upstreamed? If anyone's interested, I'll do it later and submit a pull. (They are svgs, GitHub didn't like me uploading them

application-vnd ms-publisher
application-x-qemu-disk

@madsrh
Copy link
Member Author

madsrh commented Jan 12, 2021

Nice work @Dragon8oy 👍

@Jupi007
Copy link
Member

Jupi007 commented Jan 12, 2021

It's very nice of you, thanks @Dragon8oy 👍

I just have one question: what's the name of the related mimetypes?

@stuarthayhurst
Copy link
Contributor

They're:

  • application-vnd.ms-publisher
  • application-x-qemu-disk

@Jupi007
Copy link
Member

Jupi007 commented Jan 12, 2021

Thanks 🙂
The ms-publisher icon is good.
But about the qemu one, we use the cardiogram pictogram only for virtualbox mimetypes. IMO you should replace it by something else (a symbolic version of qemu logo by example).

@madsrh
Copy link
Member Author

madsrh commented Jan 12, 2021

But about the qemu one, we use the cardiogram pictogram only for virtualbox mimetypes. IMO you should replace it by something else (a symbolic version of qemu logo by example).

+1

https://wiki.qemu.org/Logo
https://git.qemu.org/?p=qemu.git;a=blob_plain;f=pc-bios/qemu_logo.svg;hb=HEAD
Color: #ff6600

@stuarthayhurst
Copy link
Contributor

Thanks for the feedback, I've finished the publisher icon in your format and generated the bitmaps, I'll work on the qemu one and submit a pull tomorrow. Thanks :)

@stuarthayhurst
Copy link
Contributor

image
image
Thoughts?

@Jupi007
Copy link
Member

Jupi007 commented Jan 13, 2021

Thoughts?

Much better! Make the pictogram a bit smaller (it is too close to the right edge actually IMO) and it will be perfect 👍

@stuarthayhurst
Copy link
Contributor

image
Which colour did you prefer? Personally, I thought the dark grey was better.

@Jupi007
Copy link
Member

Jupi007 commented Jan 13, 2021

Perfect 😃
Personally I also prefer dark grey.

@madsrh
Copy link
Member Author

madsrh commented Jan 13, 2021

Thoughts?

How does it look with a solid fill? Similar to the snap icon

@stuarthayhurst
Copy link
Contributor

image

@Jupi007
Copy link
Member

Jupi007 commented Jan 13, 2021

Maybe also add an eye, what do you think of 🤔

@stuarthayhurst
Copy link
Contributor

image
I'm not too sure which I prefer so far. I tried it with an eye without a fill, and it didn't look right, but this looks much better than that attempt...

@Jupi007
Copy link
Member

Jupi007 commented Jan 13, 2021

I'm not too sure which I prefer so far. I tried it with an eye without a fill, and it didn't look right, but this looks much better than that attempt...

It is the best version IMO 👍

@stuarthayhurst
Copy link
Contributor

I'm happy with it, but I'll wait for some more input before I submit a PR, thanks guys :)

@Jupi007
Copy link
Member

Jupi007 commented Jan 13, 2021

thanks guys :)

No, thank you 🙂

@stuarthayhurst
Copy link
Contributor

image
image
These are the two, I'll submit whichever your team prefer :)

@Jupi007
Copy link
Member

Jupi007 commented Jan 14, 2021

Definitively prefer the solid one ;)

@Feichtmeier Feichtmeier moved this from To Do - 21.04 to Backlog in Yaru Feb 18, 2021
@bryce-carson
Copy link

I'm not much for graphic design, or working with templates in Inkscape, but I've created an icon for myself for R Markdown files.

The shape of the icon is definitely not Yaru, nor Adwaita, but comes instead from the hexagonal shapes that R Studio likes to use for their different little projects (like Tidyverse, knitR, readR, etc.).

Derivative Original
text-x-r-markdown r-markdown-logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Yaru
  
Backlog
Development

No branches or pull requests

7 participants