Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the orange - making orange more elegant #289

Closed
ghost opened this issue Mar 25, 2018 · 78 comments
Closed

Reducing the orange - making orange more elegant #289

ghost opened this issue Mar 25, 2018 · 78 comments
Labels

Comments

@ghost
Copy link

ghost commented Mar 25, 2018

Do not worry. I am not really asking for a different highlight-color. But the orange could be reduced. The theme is taking a very classy, clean and mature direction. But this is how the theme can look too:
bildschirmfoto vom 2018-03-25 22-04-54
I think it is too much of one color.
The highlight in the nautilus-sidebar is orange. Could it behave more like a clicked button?
bildschirmfoto vom 2018-03-25 22-05-44
That would mean a stronger grey. It would be more consistent to how buttons behave even when the clickable elements in the sidebar are no buttons.
The menus have a grey highlight too:
bildschirmfoto vom 2018-03-25 22-06-55
The nautilus-sidebar is the only element with this behavior (getting orange when clicked).

@CDrummond
Copy link
Contributor

Other sidebars are orange too - Settings, Tweaks, file chooser.

@ghost
Copy link
Author

ghost commented Mar 25, 2018

Yes, sorry. I meant sidebars but used the example for nautilus-sidebars. You are right. All sidebars use orange highlights. For consistency: Shouldn't they behave more like pressed buttons?

@CDrummond
Copy link
Contributor

I'm not a designer, but (IMVHO) no they should not look like buttons. To me they're like elements from a list, where one is selected - and selected list items have an orange background.

@madsrh
Copy link
Member

madsrh commented Mar 25, 2018

I know that this is the number one criticism when people try the theme. We discussed this earlier and tried a few things but landed on this pure orange.

I'll leave it up to the other guys whether this issue should be closed or needs further discussion. IMHO this is a won't fix

@Feichtmeier
Copy link
Member

Most themes, including adwaita which is the base for this theme, don't theme the sidebar as selected toggle buttons.


I would also encourage everyone to not start an issue for every bit that comes into their mind. There is already a lot of stuff to fix. Let the designers do the design and let us try to fix the issues or report actual issues. This would be just my suggestion since we all want to stay on the road, don't we? Closing this now.

@ghost
Copy link
Author

ghost commented Mar 25, 2018

Sidebars when clicked -> get orange
Buttons when clicked -> get grey
When something is clicked there is no need to use different colors.

@ghost
Copy link
Author

ghost commented Mar 25, 2018

I never said it should be themed like a button. Only the colours should behave like one.
This reaction is not fair.

@ghost
Copy link
Author

ghost commented Mar 25, 2018

At least we should try to understand each other. It is not fair to react like this when people try to help. This is a question of consistency. Similar elements react different.
No need to treat people like this.

@Feichtmeier
Copy link
Member

Feichtmeier commented Mar 25, 2018

@madsrh @clobrano feel free to re-open this
@nusinusi Keep up the good work and report bugs 👍
If it's really a stronger urge to change this you can always ask in the old issue for this. :)
Sorry if you felt offended by this! I didn't want you to feel this way :(
This can always be reopened in a sec :) don't worry

@clobrano
Copy link
Member

Sidebars when clicked -> get orange
Buttons when clicked -> get grey

@nusinusi I think there's a little misunderstanding on orange in nautilus' sidebar. The list item in sidebar is not just pressed, like a button, is also selected. You can see that once pressed even buttons get a orange highlight, so I don't see a problem of consistency here.

In the picture you posted of a contextual menu, the label is hovered, not clicked, nor selected.

@ghost
Copy link
Author

ghost commented Apr 1, 2018

Can we reopen this?

@Feichtmeier Feichtmeier reopened this Apr 1, 2018
@Feichtmeier
Copy link
Member

Reopened because of the recent discussion in
#184

@ghost ghost changed the title Reducing the orange - changing highlight in nautilus-sidebar Reducing the orange - making orange more elegant Apr 1, 2018
@ghost
Copy link
Author

ghost commented Apr 1, 2018

Is it okay, when we discuss all "reducing orange"-stuff here? We could open concrete tickets after a decision?
IMHO we should consider making the orange lines thinner. Reasons for this:

  • it looks more elegant
  • it looks more mature
  • because it is orange it is still very good visible (1920 x 1080 here. But not sure about 4k)
    here a little mockup i made with gimp:
    bildschirmfoto von 2018-04-01 15-19-52

And yes... there are places we could still add orange.

EDIT: By the way this is 1px thickness.

@CDrummond
Copy link
Contributor

@nusinusi First of all - wrong project :-) that screenshot belongs to https://github.com/ubuntu/gnome-shell-communitheme . Second - Single is too thin, perhaps a 2px thick line? (I think it's something like 3px at the moment) Also, there is not that much orange. I get it you don't like orange, but it is part of the colour scheme.

@ghost
Copy link
Author

ghost commented Apr 1, 2018

@CDrummond I asked in my post if it is okay to discuss all that stuff here. Or else we would have to open a ticket for every element we want to reduce, rethink or refine orange. @clobrano should we open a new ticket for this? It all belongs to one topic "reducing orange or make it more elegant/mature".

And sorry but this is simply not fair:

I get it you don't like orange

Why are you saying that? So any discussion is not necessary? We should discuss how we make the use of orange more elegant. I do not understand why you make it so personal. I told the reasons in my post and not that i don't like it. Tell me reasons why it should be kept how it is. That is the way we discuss this. With arguments.

@nana-4
Copy link
Contributor

nana-4 commented Apr 1, 2018

I actually thought that the orange highlights are OK, but (too) many orange folder icons are too much orange. 🍊🍊🍊🍊🍊🍊🍊🍊🍊🍊😜

Isn't there a chance to change the folder icon color (instead of reducing orange highlights of the theme)?

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 1, 2018

I absolutely love the Suru folder icons including the orange.
Not that I have anything to decide, but -1 from me 💃

Let's first see how the incoming nautilus selection will feel when seeing it "live" and then move on and see if there is any other orange that reaaally needs to be changed. Personally, I feel that this whole discussion went somehow out of place :)

@ghost
Copy link
Author

ghost commented Apr 1, 2018

I think nearly every clickable element gets grey(er) when hover. Only in gnome-shell the windows get an orange hover. I made a mockup to show another possible solution:
bildschirmfoto vom 2018-04-01 16-54-12
You can see that i used a squircel @madsrh proposed and a much thinner orange line for selected "activities" (1px). What do you think?
EDIT: I think with thinner lines we can make very sexy animations @nana-4 ;)
EDIT 2: I updated the mockup. Maybe the close-button should only get orange when hovered. This way we do not have two orange "blobs" next to each other when we hover over the window in gnome-shell. What do you think?:
bildschirmfoto vom 2018-04-01 16-54-12b

@CDrummond
Copy link
Contributor

@nusinusi sorry - no offence intended. Almost all styles use the highlight colour in the sidebars, as they highlight an item in a list. So, its consistent for Communitheme to use this. You take things too personally. My opionion is no more, or less, valid than yours. Sorry if I got the wrong impression - but you do seem to be trying to reduce the amount of orange. Hence my (incorrectly it seems) assuming you did not like this colour.

@ghost
Copy link
Author

ghost commented Apr 1, 2018

@CDrummond I really think we should reduce the amount of orange. But at the same time i accept (now) that it is part of the color-scheme. IMHO orange can be more attractive when we use it more minimalistic. Giving the theme orange accents rather than orange blocks. At the moment the communitheme seems to have at most part the following rules:

  • orange is the color for selected
  • gray is the color for hover/mouse-over

Should this be followed for the whole theme? That means for gnome-shell too (see my mockup in last post.) What do you think?
At the same time we should add orange to other places. When getting asked for the password the "enter-field" (is this the correct name?) is selected so it should be orange:
bildschirmfoto von 2018-03-29 18-08-05a

The close-button is at least for me a serious problem. Maybe it is because i wear glasses but after a time it looks like the x is moving more to the left side of the orange cirlce. When i turn my head from left to right and back the x is moving inside the circle from left to right too. When working at night the orange dot really bothers me because it takes to much attention in my field of vision. So reducing the orange here is not a matter of taste. It's about usability. What do you think about this?

@madsrh
Copy link
Member

madsrh commented Apr 2, 2018

Some thoughts on reducing orange:

Orange really isn't the an easy color for UI design, but this is part of the palette that we've been dealt.

  • The sidebar:
    I'm really looking forward to try this in the real (did @nana-4 send a PR?). I've tried this in a few mockups and I really miss the "huge block of orange" 😉 It's hard to tell if it's because I've been looking at this since november or if it's just because (almost) all themes use a solid color in the sidebar. Let's see how it feels 😃
  • The orange lines in the top-bar could be thinner. This way it looks more elegant/mature. (Maybe in stackswitcher and everywhere else too?)

Sure, but 1px might be too thin though.

  • The hover-color in gnome-shell should be gray and not orange. Because everywhere else the theme uses gray when a clickable element gets hovered (mouse-over).

Yes, the orange is too much here. Wasn't there already an issue regarding this? 🤔

  • The close-button could only be orange when hovered (mouse-over). It looks more elegant and mature this way and we would not have two orange blobs next to each other in gnome-shell.

Like the sidebar, we again already spend a lot of time discussing the window controls and landed on the orange close button. I think I personally have a foot in each camp (both for and against).
Regarding the "Activities" view, only the active window will have an orange X, the other windows will be in backdrop.
Anyway, if we change this, we will lose a IMO huge part of the branding and also the link to Ambiance. The arguments in favor of removing the color, would be more consistent window controls, Activities would look more clean and there was no orange X planned for Unity8.

  • The close-button in gnome-shell should stay orange because the window is hovered (mouse-over).

Doesn't it already do this???

When getting asked for the password the "enter-field" (is this the correct name?) is selected so it should be orange:

As @clobrano already mentioned this is the plan. @Luxamman also had some other changes to the shell design pending, but he is currently busy out in the real world 🌎

One of the few requirements that the theme has to meet, is that it is easily recognisable. By looking at a random screenshot for one second, a linux user should be able to tell that this is Ubuntu!

I have a suggestion for reduced orange myself - the selected text color. @godlyranchdressing already suggested this a few months ago, but I guess I missed that 😳 Sorry! Taken from Unity8 design here, right?
When selecting a lot of text, the current orange is really overwhelming. Lowering the opacity never looks good with orange, so this light blue might be a good solution (or a weird mix).

Also the dropdown (font, size,...) in Libreoffice is orange but gray in widget-factory. I'm guessing that's a bug?
image

One final thing, is the Calendar. IMO we should (as mentioned)never use the lower opacity orange, so I would suggest: Solid orange border for selected and gray background for the current day.

calendar

@clobrano @godlyranchdressing and others, let us know if you feel that issues should be opened for any of these.

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 2, 2018

I feel that is whole topic is getting out of control and I hope that we do not end up having just another generic "elegant" theme. Like @madsrh said this should be the ubuntu theme and everyone should know that it is ubuntu. There are a lot of ideas and I think that is great, but it is quiet hard to filter when the design process is allready finnished long ago.

Also, does commuitheme have really MORE orange than adwaita has blue? I don't think so.

Anyways...

I'll check for reducing the orange selection width in shell and make some screenshots. Is there allready an issue in shell repo for this?

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 2, 2018

I still don't want to create an issue for this until the nautilus sidebar change is live. Maybe this whole topic will calm down a bit then.


On the overview:

Let's keep in mind that what the user does in this overview - he wants to SELECT a window - hence he needs to know which window is SELECTED. He does not hang around in this overview for more than 10 secs getting depressed about orange.

Some screenshots of variations of the overview selection to get an impression in which direction we could go, if we really need to....

A) 1px border
screenshot from 2018-04-01 17-15-57

B) 4px border
screenshot from 2018-04-01 17-16-39

C) Transparent orange border
screenshot from 2018-04-01 17-24-03

D) Same thickness as "live" but with $ash border
screenshot from 2018-04-01 17-25-50

@clobrano
Copy link
Member

clobrano commented Apr 2, 2018

@clobrano should we open a new ticket for this? It all belongs to one topic "reducing orange or make it more elegant/mature".

On doubt, please write on the Forum.
In particular, it's a good practice to open one ticket for each very specific problem, so that it is easier to trace back what has been done and why. This is why it's better to discuss open and wide topics on the forum and then open tickets that reflect the decision taken.

I am not interested in reducing orange more than we already did. The only place where I feel too much of it is maybe Nautilus, because of the folders, but Suru Icons are out of our control. What if someone changes just the icon set and keep communitheme?

I actually thought that the orange highlights are OK.

I agree. I'd like to try the new mockup, because it looks nice, not because it reduces the orange.

The close-button is at least for me a serious problem. Maybe it is because I wear glasses but after a time it looks like the x is moving more to the left side of the orange circle

I wear glasses too.
Close button has been black, then an orange circle, then a squircle, then orange only on hover, then current style. Every version has been appreciated and disregarded by someone. This is normal, of course, but I learned that we cannot follow any wind. This style trace back Ambiance, with both gnome2 and unity in the last 11 years at least. Of course, if we are aware that this make feel dizzy a lot of people we surely consider to change it.

At the moment the communitheme seems to have at most part the following rules:

  • orange is the color for selected
  • gray is the color for hover/mouse-over
    ...
    Yes, the orange is too much here. Wasn't there already an issue regarding this?

There was an action to change from grey to orange and that's what we did :D

@nusinusi, this is similar as sidebar's items. Selection and hover are not mutually exclusive. In activities you both hover and select at the same time. So, to me it's OK to keep the color, and also agree that the border might be too thick. I like the first mockup by @Feichtmeier, but I should try it on the real thing and double check if it isn't too thin. @Feichtmeier if you like, please open a PR.

As @clobrano already mentioned this is the plan

Correct, this is the ticket. It does not mention directly the entries, but it's the same thing.

I have a suggestion for reduced orange myself - the selected text color. @godlyranchdressing already suggested this a few months ago, but I guess I missed that flushed Sorry! Taken from Unity8 design here, right?
When selecting a lot of text, the current orange is really overwhelming. Lowering the opacity never looks good with orange, so this light blue might be a good solution (or a weird mix).

Totally forgot that, you're right, I think we should make an exception to the rule of selection color here. Do you mind open a bug for this?

Finally, I agree with @madsrh and @Feichtmeier, "reducing orange" is not a topic for me.

@ghost
Copy link
Author

ghost commented Apr 2, 2018

@madsrh

Sure, but 1px might be too thin though.

Yes, another solution would be some kind of glow. This way it would be thicker and at the same time lose the somehow blocky look. I am +1 for making them thinner. 1px or more.

Doesn't it already do this???

Yes, i was saying it in the context of changing the highlight-color to gray. I wanted to avoid a misunderstanding i could mean the close-button too.

@clobrano

In activities you both hover and select at the same time

Hm... I am not sure about this. In activities i hover when mouse-over. When i select it i click on it and then the window gets in focus. When you go to the right the selected desktop has an orange frame. Here it is logic because it is selected. When i select another desktop by clicking on it then it gets the orange frame instead.
bildschirmfoto von 2018-04-02 14-02-53
In activities we only hover over a "possible" selection of open windows. We still do not select. Am i right?

I wear glasses too.
Close button has been black, then an orange circle, then a squircle, then orange only on hover, then current style. Every version has been appreciated and disregarded by someone. This is normal, of course, but I learned that we cannot follow any wind. This style trace back Ambiance, with both gnome2 and unity in the last 11 years at least. Of course, if we are aware that this make feel dizzy a lot of people we surely consider to change it.

A little google-research showed me that it could be a little optical illusion. When you look a the x in the close-button and move your head to the left and to the right, the x will move too inside the orange circle. You do not have this in Ambiance. I think because the x is black and the orange is darker?
I found an article with this example:
optic
You can read it up here: https://www.washingtonpost.com/news/wonk/wp/2015/02/27/12-fascinating-optical-illusions-show-how-color-can-trick-the-eye/?utm_term=.0279e8279a7f
So yes, at least for me it moves. What about you?

Another reason for removing the orange button (or make it more subtle) is that it seems like a very strong distraction. It "screams" for attention. The reason for this could be the white x which make the close-button somehow "shine" much more. Especially when working late the "shiny" orange dot on the right corner is too big of a distraction.
bildschirmfoto von 2018-04-02 14-12-45

I recommend to make it only orange on mouse-over/hover. This is the only situation when it need my attention but not when i am writing a text. This way we could keep the look of it and a complete redesign would not be necessary? At the same time we would avoid two orange dots next to each other in gnome-shell:
bildschirmfoto von 2018-04-02 14-18-35

IMHO this looks much cleaner:
bildschirmfoto vom 2018-04-01 16-54-12ba

@Feichtmeier Thank you for your mockups. IMHO version D is consistency- and usability-wise the best solution. Version C would be my next choice but IMHO it would be a design-choice because it would break consistency.

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 2, 2018

Imho grey just does not make sense. Grey means something not so important for me.
Orange means "I am doing something important now - I am going to select a window or even drag it onto another workspace"

It is the workspace overview - this is what you do here:

  • have an overview of all opened windows on the current workspace
    (the currently selected workspace is indicated on the right in the thumbnail panel)
  • then SELECT a window and eventually DRAG it onto a different workspace
  • CLOSE windows - these might be unsaved files! or even more important stuff

So this is really all more important than hovering above toggle buttons - which are grey when hovered.
I would go for A ) or B )

@jim3872
Copy link

jim3872 commented Apr 13, 2018

screenshot from 2018-04-13 20-05-01
Could the orange not be subtly changed to match the front of the orange folder icons? Helps tie it all together. The orange in the side bar looks closer to red to my eye, especially with night light mode on

@clobrano
Copy link
Member

Sorry, but What do you mean by "subtly changed"?
this orange comes from official Ubuntu palette

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 14, 2018

@jim3872 The folder icons actually consist of two orange shades. One in the back is (almost) excatly the orange of the rest of the UI and the brighter orange makes this folder look a bit more "3D". So no need to change anything, especially since we discussed another change incoming soon -> the orange box will eventually become an orange border, which you can see when you scroll up :)

Edit: oh my fault it's in a different issue :| It's somewhere believe me! Maybe even on the forum

@jim3872
Copy link

jim3872 commented Apr 14, 2018

@clobrano as in a 'fine' shade change. As described in the points raised above the ubuntu orange is monochromatic so choosing a more subtle shade/tint is doable. I don't think the folder icons are in the palette so we can forget that. But how about EB6536 (90%) over E95420 (100%)
untitled

Throwing this out there but how about light shades of Aubergine

12

The theme is looking very good overall so apologies if this comes across as nitpicking/pedantic/irritating

@Feichtmeier Will keep an eye out for for the orange box thanks

@ghost
Copy link
Author

ghost commented Apr 14, 2018

@jim3872 This is what is going to come:
https://user-images.githubusercontent.com/9556384/38165696-6829f764-3552-11e8-9c98-5e9c4c53f35d.gif
When @nana-4 finds some free time he will open a PR for it.
When the community dislikes it and we feel it does not work we would think about another solution and maybe think about changing the colour. But lets try it with the orange line like in @nana-4 s mockup. I am sure you will like it 😃
You will find it here #184

@jim3872
Copy link

jim3872 commented Apr 14, 2018

OK ill shut up then because that looks excellent :)

@godlyranchdressing
Copy link
Contributor

@nusinusi, I can't find the thread that mockup was posted in. Is that for all sidebars or just Nautilus?

@madsrh
Copy link
Member

madsrh commented Apr 17, 2018

@godlyranchdressing #184

@ghost
Copy link
Author

ghost commented Apr 17, 2018

@godlyranchdressing #184 for consistency on all sidebars. Thank you

@Feichtmeier
Copy link
Member

+1 for changing it everywhere if we change it

@ghost
Copy link
Author

ghost commented Apr 18, 2018

The state so far

So lots of refinements have landed in the theme and i want to give you a little summary of the use of orange in the communitheme.

As already stated orange is a very attention-graby color. Now the theme uses orange most times to underline something "selected" or "active" (am i using the right term?):

  1. The stackswitcher
    stackswitcher

  2. The topbar
    topbar

  3. The "categories" in shell
    shell

  4. "Active" apps in shell (at least very short underlines)
    shell2

  5. "Selected" menus (libreoffice for example)
    bildschirmfoto vom 2018-04-18 14-34-58

  6. The sidebar will use vertical orange lines because it is a vertical list (still waiting for the snap-update).
    38891360-6151b604-4284-11e8-8054-ca4d11bff177

All (selected) fields (entryfields) where the user can enter something are using orange border (please note: without glow!):

  1. Passwordfield on gnome-shell
    password

  2. Search on gnome-shell
    search2

  3. Search on gtk
    search-gtk
    The glow is already been removed by @godlyranchdressing (thank you) but the update still did not land on my snap. I will update this picture when it lands.

4.(Re)naming Files on gtk (imagine without glow - going to update the screenshots)
bildschirmfoto von 2018-04-18 14-44-13
bildschirmfoto von 2018-04-18 14-47-51

The shell uses orange for a "selected" desktop too:
shell3

So these are the places / items that use orange lines / underlines / or borders (without glow) to show the user something is selected or active.

Reasons to keep this:
By using lines and borders the orange is more subtle and at the same time functional. It asks for enough attention to get noticed by the user. It does not ask for too much attention to distract or annoy the user from his work.
When a different color would be used (lets say gray), lines could be not enough to be noticed at first sight by the user.
So by using lines and borders the attention-hungry characteristic of orange is used in an appropriate dose.

Another way the theme uses orange is by using it as some kind of little warning:
The close-button on hover
bildschirmfoto vom 2018-04-18 15-15-19

The selection of elements in nautilus uses a different kind of orange selection. Instead of lines/underlines/borders an orange background is used. This is at least a striking use of orange:
nautilus
Selected text was already changed to blue because the orange was just too strong and i would recommend to think about doing the same here.

As a office-user the system looks like this at the moment:
bildschirmfoto von 2018-04-18 15-26-31
I can completely focus on the content of my work and the systems asks for my attention only when i interact with it by using subtle and at the same time noticeable orange elements. I recommend to continue this kind of use for the color orange.

EDIT: I have still some ideas where to add orange. I can share my ideas later if you wish.

@Feichtmeier
Copy link
Member

@nusinusi Nicely summed up.
If we really keep the nautilus sidebar, we should adapt to this also in the treeviewer selection used for example in geary's left sidebar or in gthumb's left sidebar

@madsrh
Copy link
Member

madsrh commented Apr 18, 2018

@nusinusi Nicely summed up.

+1 👍

I've thought about the underline in #4 before and forgot about it again, but IMO this isn't perfect. Why not use a dot like the dock or if it has to be a line, why is it so short? There's also the app-in-a-box design that uses a semi-transparent background behind the running application, but that might not fit with the rest of our design.

BTW I also think the ALT+TAB (app-switching) should be added to the todo list.

I was pretty confident that we made a good decision with the new close button in the window controls - at least using the OS feels very Ubuntu to me - but looking at @nusinusi's office-user screenshot above, has got me a bit concerned about the lack/feeling of branding (again) 🤔I don't want to sidetrack the conversation here, just sharing my thoughts ;)

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 18, 2018

@madsrh well, I would call LO look almost "a mess" at the moment. I believe you can only fix it by heavily app-theming, which we don't want to do. Also, since ubuntu switched to GNOME LO uses that GNOME icons, previously they used the libreoffice-style-human.
(you can reduce this aweful look by 1) installing https://extensions.gnome.org/extension/1267/no-title-bar/ and 2) by switching to the experimental ribbon tabs:
screenshot from 2018-04-18 17-44-01
But that's offtopic. :)

I tried some stuff with the alt tab switcher. A 2 px border with medium_radius, but the problem is that the text labels beneath the icons get cuted by the border :| I can try some more versions later after "Feierabend"

@ghost
Copy link
Author

ghost commented Apr 18, 2018

@madsrh about ALT-Tab switching: should i open a ticket?

I can understand that you worry about the branding but the orange is still very noticeable in the theme. When you do nothing you have a lot of orange in the wallpaper and when you interact with the UI orange dots and lines appear everywhere. Orange is just too intrusive.

Nr. 4 (the underline in gnome-shell): do you want to open a ticket? Already an idea for it? I am open for both ideas: making it a dot like in the dock or making the underline longer. Even an 2px border like @Feichtmeier proposed could look ok. From me always +1 when orange gets used in lines and dots 👍
After @Feichtmeier had some "Feierabend"-beer he will be in the perfect mood of showing us how this could look like ;)

The close-button: i love it that we changed it and i fear you want to change it back. What do you think about an orange x (on hover)?
orangex
EDIT: this way we would keep the style of using thin sharp lines and dots. And now an X.
EDIT 2: please keep in mind i made the X on each end 1px "longer".

@madsrh
Copy link
Member

madsrh commented Apr 18, 2018

@nusinusi I don't want to change the close button again - I think it's good as it currently is 😃I don't think the colored X looks good even if it "keeps the style".

I would like to try some mockups for #4, but sure you can open the issues.

@Feichtmeier
Copy link
Member

screenshot from 2018-04-18 18-31-46
screenshot from 2018-04-18 18-33-00

Or just a stripe
screenshot from 2018-04-18 18-39-11

@ghost
Copy link
Author

ghost commented Apr 21, 2018

The notifications have an icon which is difficult to recognize on first sight because of the bad contrast. The color gray is used for the icons. I am going to open a ticket for it to ask increase the visibility.
The notifications appear only for a short period of time. The icon helps showing what part of the system is asking for attention (Is it the printer, a new connected device or the cloud?). Of course we read the text but the icon can be the first signal. Some users (like me) would like to see easier if a file on dropbox was updated. We already use orange for the close-button to ask the user for more attention. I recommend doing the same for the icons in notifications.
This is how it looks at the moment:
bildschirmfoto von 2018-04-19 06-15-46
On screens with high resolutions the icon is already tiny and very difficult to recognize.

Making it orange increases visibility strongly:
dropbox
(my mockups are really bad and maybe someone could make a better one)
The use of orange would be functional, logic and fit to the style of the theme. IMHO it even looks very cool.

I already suggested this and you did not like it but it seemed you only gave attention to my first mockup with the orange circle.
If this is a complete no-go for you i will at least open a ticket to suggest making the icon much darker (black) to increase the visibility.

EDIT: ticket for increasing visibility + mockup (without asking for orange): ubuntu/gnome-shell-communitheme#121

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 23, 2018

I believe we reduced the orange enough now =P
If you agree @nusinusi we should close this. But I have to thank you to be so penetrative with this, because you were right in most cases =)

@ghost
Copy link
Author

ghost commented Apr 23, 2018

Yeah we reduced enough. And it looks beautiful.
Before:
orange

And now:
bildschirmfoto von 2018-04-23 21-53-07

I hoped we could talk about where we could make tiny orange refinements: see my last post about the icons in notifications. If this is for you and the other a no-go-zone we can close this here and reopen if necessary.

@Feichtmeier
Copy link
Member

Feichtmeier commented Apr 23, 2018

Nono, just for organisation purpose. And my comment was actually a late commit/compliment on the truth of your complaints. Hope you didn't understand this wrong!
I think it would be better to open a different ticket for orange refinements because this issue here had so many PR's referring to it it gets confusing =)

@ghost
Copy link
Author

ghost commented Apr 23, 2018

Sorry for being so penetrative 😄 I think this "ticket" is a very good example of how much thought is put into this theme. Every tiny element of the theme is being discussed and put thought on. The theme is not just a product of combined tastes but a theme that looks good and can be used for productive working without annoying the user. Not sure if this was ever done for a linux-theme.
Yes, let's close it. Thank you for your patience and for the discussions.

@madsrh madsrh closed this as completed Apr 23, 2018
@ghost ghost mentioned this issue Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants