Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same icons for Fit All and Fit Selection on FreeCad. #3683

Open
leoheck opened this issue Aug 15, 2022 · 7 comments
Open

Same icons for Fit All and Fit Selection on FreeCad. #3683

leoheck opened this issue Aug 15, 2022 · 7 comments

Comments

@leoheck
Copy link

leoheck commented Aug 15, 2022

This is FreeCad,
image

It shows the same icons for Fit All and Fit Selection
image

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2022

Hi @leoheck
Thanks for the feedback.
Can you provide a screenshot of the same view but with the Adwaita icon theme?

@leoheck
Copy link
Author

leoheck commented Aug 15, 2022

Definitely, here it is @Jupi007

image

image

The first one (left to right) is the Fit All, and the Second one is the Fit Selection.

Off-topic: Those Adwaita icons are horrible, thank you all for this Yaru icon theme.

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2022

Tell me if I'm wrong: the first icon is for looking for the full document, and the second, for just a selected part?

Other question, which version of Ubuntu are you using?

Off-topic: Those Adwaita icons are horrible, thank you all for this Yaru icon theme.

Thank you very much! ❤

@leoheck
Copy link
Author

leoheck commented Aug 15, 2022

Ubuntu 22.04, but those icons have been like this since a long time ago.
The software version is Freecad Daily build (0.21). If I am not mistaken it has happened since version 0.19

The tooltips can give you a better idea of what those icons are using.

image

image

image

@Jupi007
Copy link
Member

Jupi007 commented Aug 15, 2022

Thanks @leoheck

I searched in FreeCAD sources and I found the icon name: zoom-selection.

@leoheck
Copy link
Author

leoheck commented Aug 15, 2022

Awesome, I was trying to get this name for you, unfortunately, I could not be faster to help more.

@adrianinsaval
Copy link

note that the icons displayed when setting the adwaita theme are not provided by adwaita, they are provided by FreeCAD itself but it's still a good idea to have a different icon for zoom-selection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants