Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme breaks some GTK 2 apps #827

Closed
vitalkanev opened this issue Sep 13, 2018 · 5 comments
Closed

Dark theme breaks some GTK 2 apps #827

vitalkanev opened this issue Sep 13, 2018 · 5 comments

Comments

@vitalkanev
Copy link
Contributor

Expected Behavior

It should look like as wanted

Light theme screenshot

2018-09-13 20-51-52

I think padding issue is actually known

Actual Behavior

Theme broken - press here for screenshot

2018-09-13 20-50-37

Steps to Reproduce the Problem

  1. Install and open any gtk 2.0 app - audacious is a great example
  2. Switch to dark theme (Recommended using Tweaks app)

Specifications

$ git describe
18.10.4-9-gfe6a55f4
$ lsb_release -a # Just in case
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.1 LTS
Release:	18.04
Codename:	bionic

Software that presents the issue:

  • Name: Audacious
  • Version: 3.9
@Feichtmeier
Copy link
Member

You have build it from source right?

@vitalkanev
Copy link
Contributor Author

vitalkanev commented Sep 13, 2018 via email

@Feichtmeier
Copy link
Member

The dark gtk2 is simply not there yet =)
This is all quiet new and we didnt even announce it yet.
That's why yaru-dark is not in the .deb theme in cosmic and not in the communitheme snap yet.

Until then meson will produce the yaru-dark but as you noticed, the dark gtk2 is not there yet =)

Thanks for reporting, closing this since it is not unexpected. Keep up reporting issues

@chrisjbillington
Copy link
Contributor

I just upgraded to Ubuntu 18.10, and the option to select "yaru-dark" is there in gnome-tweaks, resulting in the above for gtk2 apps.

Is is possible to make gtk2 apps continue to use the light theme, even if the dark theme is selected in gnome-tweaks, until the gtk2 dark theme is ready? (like, just aliasing the gtk2 dark theme to point to the gtk2 light theme?) Since the option is there in gnome-tweaks in Ubuntu 18.10, people are going to use it, resulting in a few apps looking pretty ugly.

@godlyranchdressing
Copy link
Contributor

@chrisjbillington You could make a symbolic link or just copy and paste the gtk-2.0 folder from regular Yaru into the dark variant's folder. The symbolic link option would be

cd /usr/share/themes/Yaru && sudo ln -s -r gtk-2.0/ ../Yaru-dark

Or you can pull from the PR that the dark GTK2 theme is being (actively) worked on:

#852 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants