Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

New API for animated icons #148

Merged
merged 5 commits into from Mar 28, 2023
Merged

New API for animated icons #148

merged 5 commits into from Mar 28, 2023

Conversation

HrX03
Copy link
Contributor

@HrX03 HrX03 commented Mar 28, 2023

Some tentative edits by following API design suggestions/requests from discord conversations.
Also introduce new music indicator animated icon and need to migrate the existing icons to the tentative API

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR @HrX03 !

I just have some nitpick suggestions 🙂
Except that, everything seems perfect!

lib/src/animated_icons/yaru_animated_icon.dart Outdated Show resolved Hide resolved
lib/src/animated_icons/yaru_animated_icon.dart Outdated Show resolved Hide resolved
lib/src/animated_icons/yaru_animated_music_indicator.dart Outdated Show resolved Hide resolved
@HrX03 HrX03 changed the title [WIP] Animated icons improvements New API for animated icons Mar 28, 2023
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Jupi007 Jupi007 merged commit a0527a4 into ubuntu:master Mar 28, 2023
@github-actions github-actions bot mentioned this pull request Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants