Skip to content
This repository has been archived by the owner on Feb 25, 2024. It is now read-only.

fix: run the animation again on data change #166

Merged
merged 1 commit into from Jul 30, 2023
Merged

fix: run the animation again on data change #166

merged 1 commit into from Jul 30, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Jul 30, 2023

  • run the animation again on animation data change (Ex: fill the icon on button click) ;
  • fix _YaruAnimatedIconState is a SingleTickerProviderStateMixin but multiple tickers were created. error when change the animation mode or duration.

Before:

Capture.video.du.2023-07-30.11-23-29.webm

After:

Capture.video.du.2023-07-30.11-22-51.webm

@Jupi007 Jupi007 added the Animated icons Related to the animated icons label Jul 30, 2023
@Jupi007 Jupi007 requested a review from Feichtmeier July 30, 2023 09:30
Feichtmeier
Feichtmeier approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh ok 👍

@Jupi007 Jupi007 merged commit 945eec8 into ubuntu:main Jul 30, 2023
1 check passed
@Jupi007 Jupi007 deleted the fix-animation-controller branch July 30, 2023 10:45
@github-actions github-actions bot mentioned this pull request Jul 30, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

Assignees
No one assigned
Labels
Animated icons Related to the animated icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @Feichtmeier