Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goldens #538

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Update goldens #538

merged 1 commit into from
Jan 18, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 18, 2023

Not sure where the sudden difference comes from but let's try what the CI says...

@Jupi007
Copy link
Member

Jupi007 commented Jan 18, 2023

Thanks, you was quicker than me :D
Looks like the diff comes from the titlebar height.

@jpnurmi jpnurmi marked this pull request as ready for review January 18, 2023 21:37
@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 18, 2023

Ah, good catch. Makes sense

@jpnurmi jpnurmi requested a review from Jupi007 January 18, 2023 21:45
@jpnurmi jpnurmi changed the title Try update goldens Update goldens Jan 18, 2023
Jupi007
Jupi007 reviewed Jan 18, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, did we recently changed the appbar height in yaru.dart? 🤔

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 18, 2023

Someone did :)

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 18, 2023 •
edited
Loading

It was released in 0.4.8 yesterday, which is why it fails now.

Jupi007
Jupi007 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks.
LGFM so 👍

@jpnurmi jpnurmi merged commit 7565d9a into ubuntu:main Jan 18, 2023
@jpnurmi jpnurmi deleted the update-goldens branch January 18, 2023 22:34
@jpnurmi jpnurmi mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Jupi007