Add YaruMasterDetailPage.orientationOf() and appBarBuilder

[jpnurmi]

No description provided.

[Jupi007]

Very cool, LGFM 👍

you just need to fix a missing comma

[jpnurmi]

@Feichtmeier does this help with the back button issue? i have a feeling it doesn't because if Navigator.of(context).canPop() didn't work for you, it sounds like you're building the title bar outside the master-detail page so you can't query the MD orientation via an inherited widget like this either?

[Feichtmeier]

ah you mean because

return Column(
      children: [
        appBar,
        Expanded(
          child: YaruMasterDetailPage(
          ```
          
          ?
          
          Well i don't know how to get this layout otherwise. Should I wrap it in a scaffold?

[jpnurmi]

I'm still trying to understand the requirements. :)

The original question was how to query MD orientation and this PR adds that mechanism but I'm afraid it's not possible to access an inherited widget from where you'd like to, above the master detail page.

We could make it possible to query the current orientation from the controller, though.

class YaruMasterDetailController extends YaruPageController {
  Orientation get orientation => ...
}

[Feichtmeier]

I'm still trying to understand the requirements. :)

The original question was how to query MD orientation and this PR adds that mechanism but I'm afraid it's not possible to access an inherited widget from where you'd like to, above the master detail page.

We could make it possible to query the current orientation from the controller, though.

class YaruMasterDetailController extends YaruPageController {
  Orientation get orientation => ...
}

Sounds enough for my case. But is this layout really so weird? 😄 Alternatively I could maybe wrap it in a scaffold?

[jpnurmi]

It's not the layout being weird or you doing anything wrong. We definitely want to support the layout you have. It's just impossible in Flutter to access an inherited widget from the context above so we need to make it possible to get the information in some other way.

Scaffold(
  appBar: YaruWindowTitleBar(
    // context OUTSIDE YaruMasterDetailPage
    // - Navigator.of(context) finds the ROOT navigator, not the MD navigator
    // - YaruMasterDetailPage.of(context) doesn't find anything
  ),
  body: YaruMasterDetailPage(
    pageBuilder: (context, index) {
      // context INSIDE YaruMasterDetailPage
      // - Navigator.of(context) finds the MD navigator
      // - YaruMasterDetailPage.of(context) is OK
    },
  ),
)

[Feichtmeier]

ah right!
I test this PR now

[Feichtmeier]

@Feichtmeier does this help with the back button issue? i have a feeling it doesn't because if Navigator.of(context).canPop() didn't work for you, it sounds like you're building the title bar outside the master-detail page so you can't query the MD orientation via an inherited widget like this either?

confirming. as the element is not reachable from down there
Thanks for trying though! If this is still an improvement you can ofc still merge as you like

[jpnurmi]

@Jupi007 @Feichtmeier do we have any use case for this?

[Jupi007]

Imo, this can be useful in some situations.
Ex: I you want to make something different in the detail view depending on the layout.

[jpnurmi]

Thanks for chiming in. I started feeling somehow unsure because this didn't solve the original issue. :)