Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YaruAutocomplete #668

Merged
merged 4 commits into from
Mar 11, 2023
Merged

Add YaruAutocomplete #668

merged 4 commits into from
Mar 11, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Mar 11, 2023 •
edited
Loading

A Yarufied version of Autocomplete:

  • uses YaruBorderContainer and MenuItemButton to gain more Yaru-like looks
  • using MenuItemButton makes it possible to customize the mouse cursor
  • optionally, allows controlling the width of the popup
Material Yaru
Light image image
Dark image image

Ref: canonical/ubuntu-desktop-installer#1532

@jpnurmi
Add YaruAutocomplete
cd9c5e7 
A Yarufied version of Autocomplete.
@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 11, 2023

Oh right, YaruBorderContainer doesn't have a default background! 😄

image

Feichtmeier
Feichtmeier approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool

@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 11, 2023

Is ColorScheme.background or ColorScheme.surface better background color for this type of menu-like popup?

Jupi007
Jupi007 approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it for now, but it looks great!

About the background, I would say to use surface, so it stands out from the background.

@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
@jpnurmi jpnurmi marked this pull request as draft March 11, 2023 12:59
@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 11, 2023

With this, we could use the same color as menus have in yaru.dart:

@jpnurmi jpnurmi marked this pull request as ready for review March 11, 2023 19:00
@jpnurmi
Copy link
Member Author

jpnurmi commented Mar 11, 2023

Looks better now

Light Dark

@jpnurmi jpnurmi merged commit e929e51 into ubuntu:main Mar 11, 2023
@jpnurmi jpnurmi deleted the autocomplete branch March 11, 2023 19:40
This was referenced Mar 11, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@Jupi007 Jupi007 Jupi007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jpnurmi @Feichtmeier @Jupi007